Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: libsrtp.gyp

Issue 639123008: [MIPS] Define 'CPU_CISC' for mips as aes calculation is incorrect for 'CPU_RISC' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/libsrtp
Patch Set: Addressing comment. Created 6 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'variables': { 6 'variables': {
7 'use_system_libsrtp%': 0, 7 'use_system_libsrtp%': 0,
8 }, 8 },
9 'target_defaults': { 9 'target_defaults': {
10 'defines': [ 10 'defines': [
(...skipping 28 matching lines...) Expand all
39 # All Windows architectures are this way. 39 # All Windows architectures are this way.
40 'SIZEOF_UNSIGNED_LONG=4', 40 'SIZEOF_UNSIGNED_LONG=4',
41 'SIZEOF_UNSIGNED_LONG_LONG=8', 41 'SIZEOF_UNSIGNED_LONG_LONG=8',
42 ], 42 ],
43 }], 43 }],
44 ['target_arch=="x64" or target_arch=="ia32"', { 44 ['target_arch=="x64" or target_arch=="ia32"', {
45 'defines': [ 45 'defines': [
46 'CPU_CISC', 46 'CPU_CISC',
47 ], 47 ],
48 }], 48 }],
49 ['target_arch=="arm" or target_arch=="armv7" or target_arch=="arm64"', { 49 ['target_arch=="arm" or target_arch=="armv7" or target_arch=="arm64" \
50 or target_arch=="mipsel" or target_arch=="mips64el"', {
50 'defines': [ 51 'defines': [
51 # TODO(leozwang): CPU_RISC doesn't work properly on android/arm 52 # TODO(leozwang): CPU_RISC doesn't work properly on android/arm and
52 # platform for unknown reasons, need to investigate the root cause 53 # mips platforms for unknown reasons, need to investigate the root
53 # of it. CPU_RISC is used for optimization only, and CPU_CISC should 54 # cause of it. CPU_RISC is used for optimization only, and CPU_CISC
54 # just work just fine, it has been tested on android/arm with srtp 55 # should just work just fine, it has been tested on android/arm with
55 # test applications and libjingle. 56 # srtp test applications and libjingle.
56 'CPU_CISC', 57 'CPU_CISC',
57 ], 58 ],
58 }], 59 }],
59 ['target_arch=="mipsel" or target_arch=="mips64el"', {
60 'defines': [
61 'CPU_RISC',
62 ],
63 }],
64 ['target_arch=="mipsel" or target_arch=="arm" or target_arch=="armv7" or t arget_arch=="ia32"', { 60 ['target_arch=="mipsel" or target_arch=="arm" or target_arch=="armv7" or t arget_arch=="ia32"', {
65 'defines': [ 61 'defines': [
66 # Define FORCE_64BIT_ALIGN to avoid alignment-related-crashes like 62 # Define FORCE_64BIT_ALIGN to avoid alignment-related-crashes like
67 # crbug/414919. Without this, aes_cbc_alloc will allocate an 63 # crbug/414919. Without this, aes_cbc_alloc will allocate an
68 # aes_cbc_ctx_t not 64-bit aligned and the v128_t members of 64 # aes_cbc_ctx_t not 64-bit aligned and the v128_t members of
69 # aes_cbc_ctx_t will not be 64-bit aligned, which breaks the 65 # aes_cbc_ctx_t will not be 64-bit aligned, which breaks the
70 # compiler optimizations that assume 64-bit alignment of v128_t. 66 # compiler optimizations that assume 64-bit alignment of v128_t.
71 'FORCE_64BIT_ALIGN', 67 'FORCE_64BIT_ALIGN',
72 ], 68 ],
73 }], 69 }],
(...skipping 27 matching lines...) Expand all
101 # All Windows architectures are this way. 97 # All Windows architectures are this way.
102 'SIZEOF_UNSIGNED_LONG=4', 98 'SIZEOF_UNSIGNED_LONG=4',
103 'SIZEOF_UNSIGNED_LONG_LONG=8', 99 'SIZEOF_UNSIGNED_LONG_LONG=8',
104 ], 100 ],
105 }], 101 }],
106 ['target_arch=="x64" or target_arch=="ia32"', { 102 ['target_arch=="x64" or target_arch=="ia32"', {
107 'defines': [ 103 'defines': [
108 'CPU_CISC', 104 'CPU_CISC',
109 ], 105 ],
110 }], 106 }],
111 ['target_arch=="mipsel" or target_arch=="mips64el"', {
112 'defines': [
113 'CPU_RISC',
114 ],
115 }],
116 ], 107 ],
117 }, 108 },
118 }, 109 },
119 'conditions': [ 110 'conditions': [
120 ['use_system_libsrtp==0', { 111 ['use_system_libsrtp==0', {
121 'targets': [ 112 'targets': [
122 { 113 {
123 'target_name': 'libsrtp', 114 'target_name': 'libsrtp',
124 'type': 'static_library', 115 'type': 'static_library',
125 'sources': [ 116 'sources': [
(...skipping 251 matching lines...) Expand 10 before | Expand all | Expand 10 after
377 'link_settings': { 368 'link_settings': {
378 'libraries': [ 369 'libraries': [
379 '-lsrtp', 370 '-lsrtp',
380 ], 371 ],
381 }, 372 },
382 }, # target libsrtp 373 }, # target libsrtp
383 ], # targets 374 ], # targets
384 }], 375 }],
385 ], 376 ],
386 } 377 }
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698