Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: libsrtp.gyp

Issue 639123008: [MIPS] Define 'CPU_CISC' for mips as aes calculation is incorrect for 'CPU_RISC' (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/deps/third_party/libsrtp
Patch Set: Addressing comment. Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: libsrtp.gyp
diff --git a/libsrtp.gyp b/libsrtp.gyp
index a3956ebeb7b66fa7fd568245a7237fd2d8bb3ccc..735810f3d18dcefc5b3cb6fb70793198ff24b7c0 100644
--- a/libsrtp.gyp
+++ b/libsrtp.gyp
@@ -46,21 +46,17 @@
'CPU_CISC',
],
}],
- ['target_arch=="arm" or target_arch=="armv7" or target_arch=="arm64"', {
+ ['target_arch=="arm" or target_arch=="armv7" or target_arch=="arm64" \
+ or target_arch=="mipsel" or target_arch=="mips64el"', {
'defines': [
- # TODO(leozwang): CPU_RISC doesn't work properly on android/arm
- # platform for unknown reasons, need to investigate the root cause
- # of it. CPU_RISC is used for optimization only, and CPU_CISC should
- # just work just fine, it has been tested on android/arm with srtp
- # test applications and libjingle.
+ # TODO(leozwang): CPU_RISC doesn't work properly on android/arm and
+ # mips platforms for unknown reasons, need to investigate the root
+ # cause of it. CPU_RISC is used for optimization only, and CPU_CISC
+ # should just work just fine, it has been tested on android/arm with
+ # srtp test applications and libjingle.
'CPU_CISC',
],
}],
- ['target_arch=="mipsel" or target_arch=="mips64el"', {
- 'defines': [
- 'CPU_RISC',
- ],
- }],
['target_arch=="mipsel" or target_arch=="arm" or target_arch=="armv7" or target_arch=="ia32"', {
'defines': [
# Define FORCE_64BIT_ALIGN to avoid alignment-related-crashes like
@@ -108,11 +104,6 @@
'CPU_CISC',
],
}],
- ['target_arch=="mipsel" or target_arch=="mips64el"', {
- 'defines': [
- 'CPU_RISC',
- ],
- }],
],
},
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698