Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 638813002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/bindings (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
haraken, Mike West
CC:
blink-reviews, dcheng
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/bindings This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183396

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+179 lines, -179 lines) Patch
M Source/bindings/core/v8/CallbackPromiseAdapter.h View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/ExceptionState.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/bindings/core/v8/ExceptionStatePlaceholder.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/bindings/core/v8/PageScriptDebugServer.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/core/v8/RetainedDOMInfo.h View 1 chunk +8 lines, -8 lines 0 comments Download
M Source/bindings/core/v8/ScriptHeapSnapshot.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptHeapSnapshot.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/ScriptProfiler.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromise.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseProperty.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromisePropertyTest.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseResolver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseResolverTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptPromiseTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptState.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptStreamer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptStreamerTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptStreamerThread.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptString.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptWrappable.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptWrappable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/SerializedScriptValue.cpp View 17 chunks +24 lines, -24 lines 0 comments Download
M Source/bindings/core/v8/V8AbstractEventListener.h View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8Binding.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/bindings/core/v8/V8ErrorHandler.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8EventListener.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8GCController.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8LazyEventListener.h View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/bindings/core/v8/V8MutationCallback.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8NodeFilterCondition.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8ScriptRunnerTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8StringResource.h View 3 chunks +6 lines, -6 lines 0 comments Download
M Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/WorkerScriptController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/WorkerScriptDebugServer.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/core/v8/custom/V8ArrayBufferCustom.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/custom/V8CustomXPathNSResolver.h View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/bindings/templates/callback_interface.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/templates/dictionary_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/TestDictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestCallbackInterface.h View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-08 04:22:14 UTC) #2
Mike West
There are a few other bindings/ patches doing this work. Why don't we let them ...
6 years, 2 months ago (2014-10-08 05:21:40 UTC) #3
Mike West
https://codereview.chromium.org/641493002/ for instance.
6 years, 2 months ago (2014-10-08 05:22:03 UTC) #4
haraken
As commented in https://codereview.chromium.org/641493002/, it seems better to land this one. LGTM.
6 years, 2 months ago (2014-10-08 05:42:09 UTC) #5
MRV
On 2014/10/08 05:42:09, haraken wrote: > As commented in https://codereview.chromium.org/641493002/, it seems better to > ...
6 years, 2 months ago (2014-10-08 05:47:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638813002/1
6 years, 2 months ago (2014-10-08 05:48:41 UTC) #8
Mike West
Ok. LGTM2. ;)
6 years, 2 months ago (2014-10-08 06:48:33 UTC) #9
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 07:49:45 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 183396

Powered by Google App Engine
This is Rietveld 408576698