Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 641493002: Replace OVERRIDE and FINAL with override and final in Source/bindings/tests (Closed)

Created:
6 years, 2 months ago by Vartul
Modified:
6 years, 2 months ago
Reviewers:
haraken, Mike West
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace OVERRIDE and FINAL with override and final in Source/bindings/tests BUG=417463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -13 lines) Patch
M Source/bindings/tests/results/core/TestDictionary.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestCallbackInterface.h View 2 chunks +12 lines, -12 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Vartul
Please review. Thanks
6 years, 2 months ago (2014-10-08 04:37:11 UTC) #2
haraken
LGTM
6 years, 2 months ago (2014-10-08 04:39:44 UTC) #3
MRV
On 2014/10/08 04:39:44, haraken wrote: > LGTM @Varthul and Mr. Haraken, I have submiited changes ...
6 years, 2 months ago (2014-10-08 05:38:44 UTC) #4
haraken
On 2014/10/08 05:38:44, MRV wrote: > On 2014/10/08 04:39:44, haraken wrote: > > LGTM > ...
6 years, 2 months ago (2014-10-08 05:41:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/641493002/1
6 years, 2 months ago (2014-10-08 05:56:45 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 06:03:30 UTC) #9
Try jobs failed on following builders:
  blink_presubmit on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/1...)

Powered by Google App Engine
This is Rietveld 408576698