Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Unified Diff: Source/bindings/core/v8/CallbackPromiseAdapter.h

Issue 638813002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/bindings (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/core/v8/ExceptionState.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/core/v8/CallbackPromiseAdapter.h
diff --git a/Source/bindings/core/v8/CallbackPromiseAdapter.h b/Source/bindings/core/v8/CallbackPromiseAdapter.h
index 9aace9ae4af8e63b71a330d81f5cde68e855993f..30cdcfc25585ed599ccb6040aec3f27d46cef82c 100644
--- a/Source/bindings/core/v8/CallbackPromiseAdapter.h
+++ b/Source/bindings/core/v8/CallbackPromiseAdapter.h
@@ -76,7 +76,7 @@ namespace blink {
// example that ownership of the WebCallbacks instance is being passed
// in and it is up to the callee to free the WebCallbacks instace.
template<typename S, typename T>
-class CallbackPromiseAdapter FINAL : public blink::WebCallbacks<typename S::WebType, typename T::WebType> {
+class CallbackPromiseAdapter final : public blink::WebCallbacks<typename S::WebType, typename T::WebType> {
public:
explicit CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver)
@@ -85,7 +85,7 @@ public:
}
virtual ~CallbackPromiseAdapter() { }
- virtual void onSuccess(typename S::WebType* result) OVERRIDE
+ virtual void onSuccess(typename S::WebType* result) override
{
if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped()) {
S::dispose(result);
@@ -94,7 +94,7 @@ public:
m_resolver->resolve(S::take(m_resolver.get(), result));
}
- virtual void onError(typename T::WebType* error) OVERRIDE
+ virtual void onError(typename T::WebType* error) override
{
if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped()) {
T::dispose(error);
@@ -109,7 +109,7 @@ private:
};
template<typename T>
-class CallbackPromiseAdapter<void, T> FINAL : public blink::WebCallbacks<void, typename T::WebType> {
+class CallbackPromiseAdapter<void, T> final : public blink::WebCallbacks<void, typename T::WebType> {
public:
explicit CallbackPromiseAdapter(PassRefPtr<ScriptPromiseResolver> resolver)
: m_resolver(resolver)
@@ -118,7 +118,7 @@ public:
}
virtual ~CallbackPromiseAdapter() { }
- virtual void onSuccess() OVERRIDE
+ virtual void onSuccess() override
{
if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped()) {
return;
@@ -126,7 +126,7 @@ public:
m_resolver->resolve(V8UndefinedType());
}
- virtual void onError(typename T::WebType* error) OVERRIDE
+ virtual void onError(typename T::WebType* error) override
{
if (!m_resolver->executionContext() || m_resolver->executionContext()->activeDOMObjectsAreStopped()) {
T::dispose(error);
« no previous file with comments | « no previous file | Source/bindings/core/v8/ExceptionState.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698