Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 638553002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/inspector (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
Mike West, dcheng
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/inspector This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183352

Patch Set 1 #

Total comments: 13

Patch Set 2 : Fixed Nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+566 lines, -572 lines) Patch
M Source/core/inspector/AsyncCallStackTracker.h View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/ConsoleMessage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ConsoleMessageStorage.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMEditor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMEditor.cpp View 23 chunks +40 lines, -40 lines 0 comments Download
M Source/core/inspector/DOMPatchSupport.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScript.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InjectedScriptCanvasModule.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorApplicationCacheAgent.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorBaseAgent.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.h View 1 4 chunks +28 lines, -30 lines 0 comments Download
M Source/core/inspector/InspectorCSSAgent.cpp View 14 chunks +28 lines, -28 lines 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.h View 1 2 chunks +16 lines, -17 lines 0 comments Download
M Source/core/inspector/InspectorCanvasAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.h View 2 chunks +9 lines, -9 lines 0 comments Download
M Source/core/inspector/InspectorConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.h View 1 2 chunks +45 lines, -46 lines 0 comments Download
M Source/core/inspector/InspectorDOMAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorDOMDebuggerAgent.h View 1 4 chunks +22 lines, -23 lines 0 comments Download
M Source/core/inspector/InspectorDOMStorageAgent.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorDebuggerAgent.h View 1 5 chunks +46 lines, -47 lines 0 comments Download
M Source/core/inspector/InspectorFrontendHost.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.h View 1 chunk +13 lines, -13 lines 0 comments Download
M Source/core/inspector/InspectorHeapProfilerAgent.cpp View 4 chunks +8 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorHistory.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorHistory.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorInputAgent.h View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorInspectorAgent.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/inspector/InspectorLayerTreeAgent.h View 2 chunks +14 lines, -14 lines 0 comments Download
M Source/core/inspector/InspectorMemoryAgent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/inspector/InspectorOverlayHost.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 4 chunks +34 lines, -34 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorProfilerAgent.h View 1 chunk +10 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.h View 2 chunks +16 lines, -16 lines 0 comments Download
M Source/core/inspector/InspectorResourceAgent.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/InspectorResourceContentLoader.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorResourceContentLoader.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorRuntimeAgent.h View 3 chunks +14 lines, -14 lines 0 comments Download
M Source/core/inspector/InspectorState.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.h View 4 chunks +24 lines, -24 lines 0 comments Download
M Source/core/inspector/InspectorStyleSheet.cpp View 2 chunks +15 lines, -15 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.h View 3 chunks +14 lines, -14 lines 0 comments Download
M Source/core/inspector/InspectorTimelineAgent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M Source/core/inspector/InspectorTracingAgent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.h View 2 chunks +12 lines, -12 lines 0 comments Download
M Source/core/inspector/InspectorWorkerAgent.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.h View 2 chunks +6 lines, -6 lines 0 comments Download
M Source/core/inspector/PageConsoleAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/PageDebuggerAgent.h View 2 chunks +13 lines, -13 lines 0 comments Download
M Source/core/inspector/PageRuntimeAgent.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/inspector/PromiseTracker.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/PromiseTracker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/inspector/ScriptCallStack.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/ScriptProfile.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/WorkerConsoleAgent.h View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.h View 2 chunks +8 lines, -8 lines 0 comments Download
M Source/core/inspector/WorkerDebuggerAgent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/WorkerInspectorController.cpp View 1 chunk +5 lines, -5 lines 0 comments Download
M Source/core/inspector/WorkerRuntimeAgent.h View 1 chunk +9 lines, -9 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-07 11:54:30 UTC) #2
Mike West
Skimming this, I see a number of lines that look like they have trailing whitespace. ...
6 years, 2 months ago (2014-10-07 13:37:15 UTC) #4
MRV
Fixed NITs PTAL https://codereview.chromium.org/638553002/diff/1/Source/core/inspector/InspectorCSSAgent.h File Source/core/inspector/InspectorCSSAgent.h (right): https://codereview.chromium.org/638553002/diff/1/Source/core/inspector/InspectorCSSAgent.h#newcode134 Source/core/inspector/InspectorCSSAgent.h:134: virtual void setStyleSheetText(ErrorString*, const String& styleSheetId, ...
6 years, 2 months ago (2014-10-07 13:59:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/638553002/20001
6 years, 2 months ago (2014-10-07 15:58:43 UTC) #7
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 17:06:48 UTC) #8
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as 183352

Powered by Google App Engine
This is Rietveld 408576698