Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1209)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: Source/core/inspector/InspectorDOMAgent.h

Issue 638553002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed Nits Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/InspectorConsoleAgent.cpp ('k') | Source/core/inspector/InspectorDOMAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorDOMAgent.h
diff --git a/Source/core/inspector/InspectorDOMAgent.h b/Source/core/inspector/InspectorDOMAgent.h
index 44a6be98fda4826ed16c486659cdb93acef8d930..e0f6300f57cfe95dc30a88bfb5bc0265a2cbd2bf 100644
--- a/Source/core/inspector/InspectorDOMAgent.h
+++ b/Source/core/inspector/InspectorDOMAgent.h
@@ -83,7 +83,7 @@ struct EventListenerInfo {
const EventListenerVector eventListenerVector;
};
-class InspectorDOMAgent FINAL : public InspectorBaseAgent<InspectorDOMAgent>, public InspectorBackendDispatcher::DOMCommandHandler {
+class InspectorDOMAgent final : public InspectorBaseAgent<InspectorDOMAgent>, public InspectorBackendDispatcher::DOMCommandHandler {
WTF_MAKE_NONCOPYABLE(InspectorDOMAgent);
public:
struct DOMListener : public WillBeGarbageCollectedMixin {
@@ -103,57 +103,56 @@ public:
static String toErrorString(ExceptionState&);
virtual ~InspectorDOMAgent();
- virtual void trace(Visitor*) OVERRIDE;
+ virtual void trace(Visitor*) override;
- virtual void setFrontend(InspectorFrontend*) OVERRIDE;
- virtual void clearFrontend() OVERRIDE;
- virtual void restore() OVERRIDE;
+ virtual void setFrontend(InspectorFrontend*) override;
+ virtual void clearFrontend() override;
+ virtual void restore() override;
WillBeHeapVector<RawPtrWillBeMember<Document> > documents();
void reset();
// Methods called from the frontend for DOM nodes inspection.
- virtual void enable(ErrorString*) OVERRIDE;
- virtual void disable(ErrorString*) OVERRIDE;
- virtual void querySelector(ErrorString*, int nodeId, const String& selectors, int* elementId) OVERRIDE;
- virtual void querySelectorAll(ErrorString*, int nodeId, const String& selectors, RefPtr<TypeBuilder::Array<int> >& result) OVERRIDE;
- virtual void getDocument(ErrorString*, RefPtr<TypeBuilder::DOM::Node>& root) OVERRIDE;
- virtual void requestChildNodes(ErrorString*, int nodeId, const int* depth) OVERRIDE;
- virtual void setAttributeValue(ErrorString*, int elementId, const String& name, const String& value) OVERRIDE;
- virtual void setAttributesAsText(ErrorString*, int elementId, const String& text, const String* name) OVERRIDE;
- virtual void removeAttribute(ErrorString*, int elementId, const String& name) OVERRIDE;
- virtual void removeNode(ErrorString*, int nodeId) OVERRIDE;
- virtual void setNodeName(ErrorString*, int nodeId, const String& name, int* newId) OVERRIDE;
- virtual void getOuterHTML(ErrorString*, int nodeId, WTF::String* outerHTML) OVERRIDE;
- virtual void setOuterHTML(ErrorString*, int nodeId, const String& outerHTML) OVERRIDE;
- virtual void setNodeValue(ErrorString*, int nodeId, const String& value) OVERRIDE;
- virtual void getEventListenersForNode(ErrorString*, int nodeId, const WTF::String* objectGroup, RefPtr<TypeBuilder::Array<TypeBuilder::DOM::EventListener> >& listenersArray) OVERRIDE;
- virtual void performSearch(ErrorString*, const String& whitespaceTrimmedQuery, const bool* includeUserAgentShadowDOM, String* searchId, int* resultCount) OVERRIDE;
- virtual void getSearchResults(ErrorString*, const String& searchId, int fromIndex, int toIndex, RefPtr<TypeBuilder::Array<int> >&) OVERRIDE;
- virtual void discardSearchResults(ErrorString*, const String& searchId) OVERRIDE;
- virtual void resolveNode(ErrorString*, int nodeId, const String* objectGroup, RefPtr<TypeBuilder::Runtime::RemoteObject>& result) OVERRIDE;
- virtual void getAttributes(ErrorString*, int nodeId, RefPtr<TypeBuilder::Array<String> >& result) OVERRIDE;
- virtual void setInspectModeEnabled(ErrorString*, bool enabled, const bool* inspectUAShadowDOM, const RefPtr<JSONObject>* highlightConfig) OVERRIDE;
- virtual void requestNode(ErrorString*, const String& objectId, int* nodeId) OVERRIDE;
- virtual void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId) OVERRIDE;
- virtual void pushNodesByBackendIdsToFrontend(ErrorString*, const RefPtr<JSONArray>& nodeIds, RefPtr<TypeBuilder::Array<int> >&) OVERRIDE;
- virtual void hideHighlight(ErrorString*) OVERRIDE;
- virtual void highlightRect(ErrorString*, int x, int y, int width, int height, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) OVERRIDE;
- virtual void highlightQuad(ErrorString*, const RefPtr<JSONArray>& quad, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) OVERRIDE;
- virtual void highlightNode(ErrorString*, const RefPtr<JSONObject>& highlightConfig, const int* nodeId, const String* objectId) OVERRIDE;
- virtual void highlightFrame(ErrorString*, const String& frameId, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) OVERRIDE;
-
- virtual void copyTo(ErrorString*, int nodeId, int targetElementId, const int* anchorNodeId, int* newNodeId) OVERRIDE;
- virtual void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* anchorNodeId, int* newNodeId) OVERRIDE;
- virtual void undo(ErrorString*) OVERRIDE;
- virtual void redo(ErrorString*) OVERRIDE;
- virtual void markUndoableState(ErrorString*) OVERRIDE;
- virtual void focus(ErrorString*, int nodeId) OVERRIDE;
- virtual void setFileInputFiles(ErrorString*, int nodeId, const RefPtr<JSONArray>& files) OVERRIDE;
- virtual void getBoxModel(ErrorString*, int nodeId, RefPtr<TypeBuilder::DOM::BoxModel>&) OVERRIDE;
- virtual void getNodeForLocation(ErrorString*, int x, int y, int* nodeId) OVERRIDE;
- virtual void getRelayoutBoundary(ErrorString*, int nodeId, int* relayoutBoundaryNodeId) OVERRIDE;
-
+ virtual void enable(ErrorString*) override;
+ virtual void disable(ErrorString*) override;
+ virtual void querySelector(ErrorString*, int nodeId, const String& selectors, int* elementId) override;
+ virtual void querySelectorAll(ErrorString*, int nodeId, const String& selectors, RefPtr<TypeBuilder::Array<int> >& result) override;
+ virtual void getDocument(ErrorString*, RefPtr<TypeBuilder::DOM::Node>& root) override;
+ virtual void requestChildNodes(ErrorString*, int nodeId, const int* depth) override;
+ virtual void setAttributeValue(ErrorString*, int elementId, const String& name, const String& value) override;
+ virtual void setAttributesAsText(ErrorString*, int elementId, const String& text, const String* name) override;
+ virtual void removeAttribute(ErrorString*, int elementId, const String& name) override;
+ virtual void removeNode(ErrorString*, int nodeId) override;
+ virtual void setNodeName(ErrorString*, int nodeId, const String& name, int* newId) override;
+ virtual void getOuterHTML(ErrorString*, int nodeId, WTF::String* outerHTML) override;
+ virtual void setOuterHTML(ErrorString*, int nodeId, const String& outerHTML) override;
+ virtual void setNodeValue(ErrorString*, int nodeId, const String& value) override;
+ virtual void getEventListenersForNode(ErrorString*, int nodeId, const WTF::String* objectGroup, RefPtr<TypeBuilder::Array<TypeBuilder::DOM::EventListener> >& listenersArray) override;
+ virtual void performSearch(ErrorString*, const String& whitespaceTrimmedQuery, const bool* includeUserAgentShadowDOM, String* searchId, int* resultCount) override;
+ virtual void getSearchResults(ErrorString*, const String& searchId, int fromIndex, int toIndex, RefPtr<TypeBuilder::Array<int> >&) override;
+ virtual void discardSearchResults(ErrorString*, const String& searchId) override;
+ virtual void resolveNode(ErrorString*, int nodeId, const String* objectGroup, RefPtr<TypeBuilder::Runtime::RemoteObject>& result) override;
+ virtual void getAttributes(ErrorString*, int nodeId, RefPtr<TypeBuilder::Array<String> >& result) override;
+ virtual void setInspectModeEnabled(ErrorString*, bool enabled, const bool* inspectUAShadowDOM, const RefPtr<JSONObject>* highlightConfig) override;
+ virtual void requestNode(ErrorString*, const String& objectId, int* nodeId) override;
+ virtual void pushNodeByPathToFrontend(ErrorString*, const String& path, int* nodeId) override;
+ virtual void pushNodesByBackendIdsToFrontend(ErrorString*, const RefPtr<JSONArray>& nodeIds, RefPtr<TypeBuilder::Array<int> >&) override;
+ virtual void hideHighlight(ErrorString*) override;
+ virtual void highlightRect(ErrorString*, int x, int y, int width, int height, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) override;
+ virtual void highlightQuad(ErrorString*, const RefPtr<JSONArray>& quad, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) override;
+ virtual void highlightNode(ErrorString*, const RefPtr<JSONObject>& highlightConfig, const int* nodeId, const String* objectId) override;
+ virtual void highlightFrame(ErrorString*, const String& frameId, const RefPtr<JSONObject>* color, const RefPtr<JSONObject>* outlineColor) override;
+
+ virtual void copyTo(ErrorString*, int nodeId, int targetElementId, const int* anchorNodeId, int* newNodeId) override;
+ virtual void moveTo(ErrorString*, int nodeId, int targetNodeId, const int* anchorNodeId, int* newNodeId) override;
+ virtual void undo(ErrorString*) override;
+ virtual void redo(ErrorString*) override;
+ virtual void markUndoableState(ErrorString*) override;
+ virtual void focus(ErrorString*, int nodeId) override;
+ virtual void setFileInputFiles(ErrorString*, int nodeId, const RefPtr<JSONArray>& files) override;
+ virtual void getBoxModel(ErrorString*, int nodeId, RefPtr<TypeBuilder::DOM::BoxModel>&) override;
+ virtual void getNodeForLocation(ErrorString*, int x, int y, int* nodeId) override;
+ virtual void getRelayoutBoundary(ErrorString*, int nodeId, int* relayoutBoundaryNodeId) override;
static void getEventListeners(EventTarget*, Vector<EventListenerInfo>& listenersArray, bool includeAncestors);
class Listener : public WillBeGarbageCollectedMixin {
« no previous file with comments | « Source/core/inspector/InspectorConsoleAgent.cpp ('k') | Source/core/inspector/InspectorDOMAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698