Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(173)

Issues Search
    My Issues | Starred     Open | Closed | All

Side by Side Diff: Source/core/inspector/InspectorConsoleAgent.h

Issue 638553002: Replace FINAL and OVERRIDE with their C++11 counterparts in Source/core/inspector (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed Nits Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/inspector/InspectorCanvasAgent.cpp ('k') | Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011 Google Inc. All rights reserved. 2 * Copyright (C) 2011 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 class WorkerGlobalScopeProxy; 60 class WorkerGlobalScopeProxy;
61 class XMLHttpRequest; 61 class XMLHttpRequest;
62 62
63 typedef String ErrorString; 63 typedef String ErrorString;
64 64
65 class InspectorConsoleAgent : public InspectorBaseAgent<InspectorConsoleAgent>, public InspectorBackendDispatcher::ConsoleCommandHandler { 65 class InspectorConsoleAgent : public InspectorBaseAgent<InspectorConsoleAgent>, public InspectorBackendDispatcher::ConsoleCommandHandler {
66 WTF_MAKE_NONCOPYABLE(InspectorConsoleAgent); 66 WTF_MAKE_NONCOPYABLE(InspectorConsoleAgent);
67 public: 67 public:
68 InspectorConsoleAgent(InspectorTimelineAgent*, InjectedScriptManager*); 68 InspectorConsoleAgent(InspectorTimelineAgent*, InjectedScriptManager*);
69 virtual ~InspectorConsoleAgent(); 69 virtual ~InspectorConsoleAgent();
70 virtual void trace(Visitor*) OVERRIDE; 70 virtual void trace(Visitor*) override;
71 71
72 virtual void enable(ErrorString*) OVERRIDE FINAL; 72 virtual void enable(ErrorString*) override final;
73 virtual void disable(ErrorString*) OVERRIDE FINAL; 73 virtual void disable(ErrorString*) override final;
74 virtual void clearMessages(ErrorString*) OVERRIDE; 74 virtual void clearMessages(ErrorString*) override;
75 bool enabled() { return m_enabled; } 75 bool enabled() { return m_enabled; }
76 76
77 virtual void setFrontend(InspectorFrontend*) OVERRIDE FINAL; 77 virtual void setFrontend(InspectorFrontend*) override final;
78 virtual void clearFrontend() OVERRIDE FINAL; 78 virtual void clearFrontend() override final;
79 virtual void restore() OVERRIDE FINAL; 79 virtual void restore() override final;
80 80
81 void addMessageToConsole(ConsoleMessage*); 81 void addMessageToConsole(ConsoleMessage*);
82 void consoleMessagesCleared(); 82 void consoleMessagesCleared();
83 83
84 void setTracingBasedTimeline(ErrorString*, bool enabled); 84 void setTracingBasedTimeline(ErrorString*, bool enabled);
85 void consoleTimeline(ExecutionContext*, const String& title, ScriptState*); 85 void consoleTimeline(ExecutionContext*, const String& title, ScriptState*);
86 void consoleTimelineEnd(ExecutionContext*, const String& title, ScriptState* ); 86 void consoleTimelineEnd(ExecutionContext*, const String& title, ScriptState* );
87 87
88 void didCommitLoad(LocalFrame*, DocumentLoader*); 88 void didCommitLoad(LocalFrame*, DocumentLoader*);
89 89
90 void didFinishXHRLoading(XMLHttpRequest*, ThreadableLoaderClient*, unsigned long requestIdentifier, ScriptString, const AtomicString& method, const String& url, const String& sendURL, unsigned sendLineNumber); 90 void didFinishXHRLoading(XMLHttpRequest*, ThreadableLoaderClient*, unsigned long requestIdentifier, ScriptString, const AtomicString& method, const String& url, const String& sendURL, unsigned sendLineNumber);
91 void addProfileFinishedMessageToConsole(PassRefPtrWillBeRawPtr<ScriptProfile >, unsigned lineNumber, const String& sourceURL); 91 void addProfileFinishedMessageToConsole(PassRefPtrWillBeRawPtr<ScriptProfile >, unsigned lineNumber, const String& sourceURL);
92 void addStartProfilingMessageToConsole(const String& title, unsigned lineNum ber, const String& sourceURL); 92 void addStartProfilingMessageToConsole(const String& title, unsigned lineNum ber, const String& sourceURL);
93 virtual void setMonitoringXHREnabled(ErrorString*, bool enabled) OVERRIDE; 93 virtual void setMonitoringXHREnabled(ErrorString*, bool enabled) override;
94 virtual void addInspectedNode(ErrorString*, int nodeId) = 0; 94 virtual void addInspectedNode(ErrorString*, int nodeId) = 0;
95 virtual void addInspectedHeapObject(ErrorString*, int inspectedHeapObjectId) OVERRIDE; 95 virtual void addInspectedHeapObject(ErrorString*, int inspectedHeapObjectId) override;
96 96
97 virtual bool isWorkerAgent() = 0; 97 virtual bool isWorkerAgent() = 0;
98 98
99 protected: 99 protected:
100 void sendConsoleMessageToFrontend(ConsoleMessage*, bool generatePreview); 100 void sendConsoleMessageToFrontend(ConsoleMessage*, bool generatePreview);
101 virtual ConsoleMessageStorage* messageStorage() = 0; 101 virtual ConsoleMessageStorage* messageStorage() = 0;
102 102
103 RawPtrWillBeMember<InspectorTimelineAgent> m_timelineAgent; 103 RawPtrWillBeMember<InspectorTimelineAgent> m_timelineAgent;
104 RawPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager; 104 RawPtrWillBeMember<InjectedScriptManager> m_injectedScriptManager;
105 InspectorFrontend::Console* m_frontend; 105 InspectorFrontend::Console* m_frontend;
106 bool m_enabled; 106 bool m_enabled;
107 private: 107 private:
108 static int s_enabledAgentCount; 108 static int s_enabledAgentCount;
109 }; 109 };
110 110
111 } // namespace blink 111 } // namespace blink
112 112
113 113
114 #endif // !defined(InspectorConsoleAgent_h) 114 #endif // !defined(InspectorConsoleAgent_h)
OLDNEW
« no previous file with comments | « Source/core/inspector/InspectorCanvasAgent.cpp ('k') | Source/core/inspector/InspectorConsoleAgent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698