Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(699)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 637913003: Revert of "Converted LayerImpl::bounds() to return SizeF." (Closed)

Created:
6 years, 2 months ago by bokan
Modified:
6 years, 2 months ago
Reviewers:
CC:
chromium-reviews, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of "Converted LayerImpl::bounds() to return SizeF." Seems this was more contentious than originally anticipated. Reverting this until we have consensus on how to go forward. TBR=aelias@chromium.org,enne@chromium.org,danakj@chromium.org BUG= Committed: https://crrev.com/cccfde7dac913451d92e9cd44e3d77a7f913be43 Cr-Commit-Position: refs/heads/master@{#298710}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -208 lines) Patch
M cc/debug/debug_rect_history.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/layers/delegated_renderer_layer_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/heads_up_display_layer_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M cc/layers/layer_impl.h View 2 chunks +4 lines, -1 line 0 comments Download
M cc/layers/layer_impl.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M cc/layers/layer_impl_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M cc/layers/painted_scrollbar_layer_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M cc/layers/picture_image_layer_impl_unittest.cc View 1 3 chunks +3 lines, -5 lines 0 comments Download
M cc/layers/picture_layer.cc View 2 chunks +1 line, -3 lines 0 comments Download
M cc/layers/picture_layer_impl.cc View 3 chunks +3 lines, -7 lines 0 comments Download
M cc/layers/picture_layer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/layers/ui_resource_layer_impl.cc View 1 2 chunks +1 line, -2 lines 0 comments Download
M cc/layers/ui_resource_layer_impl_unittest.cc View 3 chunks +2 lines, -3 lines 0 comments Download
M cc/test/layer_tree_json_parser.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M cc/trees/damage_tracker.cc View 3 chunks +2 lines, -5 lines 0 comments Download
M cc/trees/damage_tracker_unittest.cc View 5 chunks +7 lines, -10 lines 0 comments Download
M cc/trees/layer_tree_host_common_unittest.cc View 35 chunks +34 lines, -108 lines 0 comments Download
M cc/trees/layer_tree_host_impl.cc View 1 chunk +1 line, -3 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M cc/trees/layer_tree_host_unittest.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M cc/trees/layer_tree_host_unittest_scroll.cc View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M cc/trees/layer_tree_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M cc/trees/layer_tree_impl_unittest.cc View 22 chunks +22 lines, -22 lines 0 comments Download
M cc/trees/occlusion_tracker_unittest.cc View 4 chunks +3 lines, -8 lines 0 comments Download
M cc/trees/tree_synchronizer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/637913003/20001
6 years, 2 months ago (2014-10-08 14:03:30 UTC) #2
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 0be57ef7ee5f4c2c09306410cdb7a03f24b35c4a
6 years, 2 months ago (2014-10-08 15:15:34 UTC) #3
commit-bot: I haz the power
6 years, 2 months ago (2014-10-08 15:16:22 UTC) #4
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cccfde7dac913451d92e9cd44e3d77a7f913be43
Cr-Commit-Position: refs/heads/master@{#298710}

Powered by Google App Engine
This is Rietveld 408576698