cc: Pass Occlusion instead of OcclusionTracker to LayerImpls

cc: Pass Occlusion instead of OcclusionTracker to LayerImpls

This patch updates LayerImpls to accept Occlusion into AppendQuads
instead of OcclusionTracker. This makes it possible for the layer
to retain a local copy for whatever reason, and restricts the code
from modifying occlusion information in unexpected ways.

R=danakj

Committed: https://crrev.com/11b77b43a0cc725b4acfc7a1a13441a1ad8e2d97
Cr-Commit-Position: refs/heads/master@{#298556}

[vmpstr, 2014-10-07 06:44:35]

PTAL

https://codereview.chromium.org/633773004/diff/1/cc/layers/picture_layer_impl.cc
File cc/layers/picture_layer_impl.cc (left):

https://codereview.chromium.org/633773004/diff/1/cc/layers/picture_layer_impl...
cc/layers/picture_layer_impl.cc:173: draw_properties().target_space_transform,
Transform here went away.

https://codereview.chromium.org/633773004/diff/1/cc/layers/solid_color_layer_...
File cc/layers/solid_color_layer_impl.h (left):

https://codereview.chromium.org/633773004/diff/1/cc/layers/solid_color_layer_...
cc/layers/solid_color_layer_impl.h:26: const gfx::Transform&
target_space_transform,
Transform removed.

https://codereview.chromium.org/633773004/diff/1/cc/trees/layer_tree_host_imp...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/633773004/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.cc:551:
occlusion_tracker.GetCurrentOcclusionForLayer(layer->draw_transform()),
This is where "conversion" actually happens.

[danakj, 2014-10-07 17:01:23]

LGTM

https://codereview.chromium.org/633773004/diff/1/cc/layers/heads_up_display_l...
File cc/layers/heads_up_display_layer_impl_unittest.cc (right):

https://codereview.chromium.org/633773004/diff/1/cc/layers/heads_up_display_l...
cc/layers/heads_up_display_layer_impl_unittest.cc:10: #include
"cc/test/mock_occlusion_tracker.h"
update this?

https://codereview.chromium.org/633773004/diff/1/cc/test/layer_test_common.cc
File cc/test/layer_test_common.cc (right):

https://codereview.chromium.org/633773004/diff/1/cc/test/layer_test_common.cc...
cc/test/layer_test_common.cc:130:
occlusion_tracker_.GetCurrentOcclusionForLayer(
How about just construct an Occlusion with the |occluded| rect in it? and drop
the tracker_ member entirely

https://codereview.chromium.org/633773004/diff/1/cc/test/layer_test_common.cc...
cc/test/layer_test_common.cc:147:
occlusion_tracker_.GetCurrentOcclusionForLayer(
ditto

https://codereview.chromium.org/633773004/diff/1/cc/trees/layer_tree_host_imp...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/633773004/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.cc:572: occlusion_tracker,
surfaceimpl comes next i guess?

[vmpstr, 2014-10-07 18:50:10]

https://codereview.chromium.org/633773004/diff/1/cc/layers/heads_up_display_l...
File cc/layers/heads_up_display_layer_impl_unittest.cc (right):

https://codereview.chromium.org/633773004/diff/1/cc/layers/heads_up_display_l...
cc/layers/heads_up_display_layer_impl_unittest.cc:10: #include
"cc/test/mock_occlusion_tracker.h"
On 2014/10/07 17:01:23, danakj wrote:
> update this?

Done.

https://codereview.chromium.org/633773004/diff/1/cc/test/layer_test_common.cc
File cc/test/layer_test_common.cc (right):

https://codereview.chromium.org/633773004/diff/1/cc/test/layer_test_common.cc...
cc/test/layer_test_common.cc:130:
occlusion_tracker_.GetCurrentOcclusionForLayer(
On 2014/10/07 17:01:23, danakj wrote:
> How about just construct an Occlusion with the |occluded| rect in it? and drop
> the tracker_ member entirely

Constructed Occlusion, keeping the tracker around for now (see below).

https://codereview.chromium.org/633773004/diff/1/cc/test/layer_test_common.cc...
cc/test/layer_test_common.cc:160:
occlusion_tracker_.set_occluded_target_rect_for_contributing_surface(
I gotta keep it around, beacuse of this. Once I convert surface impl, I will
remove it altogether.

https://codereview.chromium.org/633773004/diff/1/cc/trees/layer_tree_host_imp...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/633773004/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.cc:572: occlusion_tracker,
On 2014/10/07 17:01:23, danakj wrote:
> surfaceimpl comes next i guess?

That's the plan. Then possibly cc::Layer::Update call, but I first gotta figure
out what it does with the tracker.

[vmpstr, 2014-10-07 18:50:38]

The CQ bit was checked by vmpstr@chromium.org

[commit-bot: I haz the power, 2014-10-07 18:52:14]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/633773004/20001

[danakj, 2014-10-07 18:54:26]

https://codereview.chromium.org/633773004/diff/1/cc/trees/layer_tree_host_imp...
File cc/trees/layer_tree_host_impl.cc (right):

https://codereview.chromium.org/633773004/diff/1/cc/trees/layer_tree_host_imp...
cc/trees/layer_tree_host_impl.cc:572: occlusion_tracker,
On 2014/10/07 18:50:10, vmpstr wrote:
> On 2014/10/07 17:01:23, danakj wrote:
> > surfaceimpl comes next i guess?
> 
> That's the plan. Then possibly cc::Layer::Update call, but I first gotta
figure
> out what it does with the tracker.

TiledLayer calls Occluded() on it to paint-cull. Think that's it.

[commit-bot: I haz the power, 2014-10-07 20:11:55]

Committed patchset #2 (id:20001) as 6b6dfad5040f783367be746310004dfe50cfadbf

[commit-bot: I haz the power, 2014-10-07 20:12:39]

Patchset 2 (id:??) landed as
https://crrev.com/11b77b43a0cc725b4acfc7a1a13441a1ad8e2d97
Cr-Commit-Position: refs/heads/master@{#298556}