cc: Pass Occlusion instead of OcclusionTracker to LayerImpls

cc/test/layer_test_common.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/layer_test_common.h"
 
 #include "cc/base/math_util.h"
 #include "cc/base/region.h"
 #include "cc/layers/append_quads_data.h"
 #include "cc/quads/draw_quad.h"
@@ skipping 108 matching lines @@
 
 void LayerTestCommon::LayerImplTest::AppendQuadsWithOcclusion(
     LayerImpl* layer_impl,
     const gfx::Rect& occluded) {
   AppendQuadsData data;
 
   render_pass_->quad_list.clear();
   render_pass_->shared_quad_state_list.clear();
   occlusion_tracker_.set_occluded_target_rect(occluded);
   layer_impl->WillDraw(DRAW_MODE_HARDWARE, resource_provider());
-  layer_impl->AppendQuads(render_pass_.get(), occlusion_tracker_, &data);
+  layer_impl->AppendQuads(render_pass_.get(),
+                          occlusion_tracker_.GetCurrentOcclusionForLayer(

[danakj, 2014/10/07 17:01:23]

How about just construct an Occlusion with the |occluded| rect in it? and drop
the tracker_ member entirely

[vmpstr, 2014/10/07 18:50:09]

Constructed Occlusion, keeping the tracker around for now (see below).

+                              layer_impl->draw_transform()),
+                          &data);
   layer_impl->DidDraw(resource_provider());
 }
 
 void LayerTestCommon::LayerImplTest::AppendQuadsForPassWithOcclusion(
     LayerImpl* layer_impl,
     const RenderPassId& id,
     const gfx::Rect& occluded) {
   AppendQuadsData data(id);
 
   render_pass_->quad_list.clear();
   render_pass_->shared_quad_state_list.clear();
   occlusion_tracker_.set_occluded_target_rect(occluded);
   layer_impl->WillDraw(DRAW_MODE_HARDWARE, resource_provider());
-  layer_impl->AppendQuads(render_pass_.get(), occlusion_tracker_, &data);
+  layer_impl->AppendQuads(render_pass_.get(),
+                          occlusion_tracker_.GetCurrentOcclusionForLayer(

[danakj, 2014/10/07 17:01:23]

ditto

+                              layer_impl->draw_transform()),
+                          &data);
   layer_impl->DidDraw(resource_provider());
 }
 
 void LayerTestCommon::LayerImplTest::AppendSurfaceQuadsWithOcclusion(
     RenderSurfaceImpl* surface_impl,
     const gfx::Rect& occluded) {
   AppendQuadsData data;
 
   render_pass_->quad_list.clear();
   render_pass_->shared_quad_state_list.clear();
   occlusion_tracker_.set_occluded_target_rect_for_contributing_surface(

[vmpstr, 2014/10/07 18:50:10]

I gotta keep it around, beacuse of this. Once I convert surface impl, I will
remove it altogether.

       occluded);
   bool for_replica = false;
   RenderPassId id(1, 1);
   surface_impl->AppendQuads(
       render_pass_.get(), occlusion_tracker_, &data, for_replica, id);
 }
 
 }  // namespace cc