Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 633343002: Use C++11 range based iteration for invalidation sets. (Closed)

Created:
6 years, 2 months ago by rune
Modified:
6 years, 2 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis, rune+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Use C++11 range based iteration for invalidation sets. Shortens down the source and improves readability. Also removed a left-over include. R=chrishtr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183416

Patch Set 1 #

Total comments: 2

Patch Set 2 : Review issue: renamed variables #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -41 lines) Patch
M Source/core/css/RuleFeature.cpp View 1 3 chunks +12 lines, -13 lines 0 comments Download
M Source/core/css/invalidation/DescendantInvalidationSet.cpp View 1 3 chunks +20 lines, -24 lines 0 comments Download
M Source/core/css/invalidation/StyleInvalidator.cpp View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 12 (3 generated)
rune
6 years, 2 months ago (2014-10-08 07:05:56 UTC) #1
Timothy Loh
https://codereview.chromium.org/633343002/diff/1/Source/core/css/RuleFeature.cpp File Source/core/css/RuleFeature.cpp (right): https://codereview.chromium.org/633343002/diff/1/Source/core/css/RuleFeature.cpp#newcode308 Source/core/css/RuleFeature.cpp:308: for (const auto& it : features.classes) Should probably update ...
6 years, 2 months ago (2014-10-08 07:15:00 UTC) #3
rune
On 2014/10/08 at 07:15:00, timloh wrote: > https://codereview.chromium.org/633343002/diff/1/Source/core/css/RuleFeature.cpp > File Source/core/css/RuleFeature.cpp (right): > > https://codereview.chromium.org/633343002/diff/1/Source/core/css/RuleFeature.cpp#newcode308 ...
6 years, 2 months ago (2014-10-08 07:25:21 UTC) #4
rune
https://codereview.chromium.org/633343002/diff/1/Source/core/css/RuleFeature.cpp File Source/core/css/RuleFeature.cpp (right): https://codereview.chromium.org/633343002/diff/1/Source/core/css/RuleFeature.cpp#newcode308 Source/core/css/RuleFeature.cpp:308: for (const auto& it : features.classes) On 2014/10/08 at ...
6 years, 2 months ago (2014-10-08 07:35:33 UTC) #5
Timothy Loh
On 2014/10/08 07:35:33, rune wrote: > https://codereview.chromium.org/633343002/diff/1/Source/core/css/RuleFeature.cpp > File Source/core/css/RuleFeature.cpp (right): > > https://codereview.chromium.org/633343002/diff/1/Source/core/css/RuleFeature.cpp#newcode308 > ...
6 years, 2 months ago (2014-10-08 11:26:23 UTC) #6
Mike West
Drive-by <3 C++11 lgtm. :) Thanks for cleaning this up; the result is much more ...
6 years, 2 months ago (2014-10-08 12:19:54 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/633343002/20001
6 years, 2 months ago (2014-10-08 13:03:43 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 183416
6 years, 2 months ago (2014-10-08 15:07:42 UTC) #11
chrishtr
6 years, 2 months ago (2014-10-08 16:22:09 UTC) #12
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698