Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(679)

Unified Diff: Source/core/css/RuleFeature.cpp

Issue 633343002: Use C++11 range based iteration for invalidation sets. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review issue: renamed variables Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/core/css/invalidation/DescendantInvalidationSet.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/RuleFeature.cpp
diff --git a/Source/core/css/RuleFeature.cpp b/Source/core/css/RuleFeature.cpp
index 250988215f7eec346be477df3f55375af0de70d8..47f6af4c60f6562539866c75a390f3ed2e3f2082 100644
--- a/Source/core/css/RuleFeature.cpp
+++ b/Source/core/css/RuleFeature.cpp
@@ -37,7 +37,6 @@
#include "core/css/invalidation/DescendantInvalidationSet.h"
#include "core/dom/Element.h"
#include "core/dom/Node.h"
-#include "platform/RuntimeEnabledFeatures.h"
#include "wtf/BitVector.h"
namespace blink {
@@ -306,10 +305,10 @@ void RuleFeatureSet::addFeaturesToInvalidationSets(const CSSSelector& selector,
invalidationSet->addId(features.id);
if (!features.tagName.isEmpty())
invalidationSet->addTagName(features.tagName);
- for (Vector<AtomicString>::const_iterator it = features.classes.begin(); it != features.classes.end(); ++it)
- invalidationSet->addClass(*it);
- for (Vector<AtomicString>::const_iterator it = features.attributes.begin(); it != features.attributes.end(); ++it)
- invalidationSet->addAttribute(*it);
+ for (const auto& className : features.classes)
+ invalidationSet->addClass(className);
+ for (const auto& attribute : features.attributes)
+ invalidationSet->addAttribute(attribute);
if (features.customPseudoElement)
invalidationSet->setCustomPseudoInvalid();
}
@@ -449,14 +448,14 @@ void RuleFeatureSet::FeatureMetadata::clear()
void RuleFeatureSet::add(const RuleFeatureSet& other)
{
- for (InvalidationSetMap::const_iterator it = other.m_classInvalidationSets.begin(); it != other.m_classInvalidationSets.end(); ++it)
- ensureClassInvalidationSet(it->key).combine(*it->value);
- for (InvalidationSetMap::const_iterator it = other.m_attributeInvalidationSets.begin(); it != other.m_attributeInvalidationSets.end(); ++it)
- ensureAttributeInvalidationSet(it->key).combine(*it->value);
- for (InvalidationSetMap::const_iterator it = other.m_idInvalidationSets.begin(); it != other.m_idInvalidationSets.end(); ++it)
- ensureIdInvalidationSet(it->key).combine(*it->value);
- for (PseudoTypeInvalidationSetMap::const_iterator it = other.m_pseudoInvalidationSets.begin(); it != other.m_pseudoInvalidationSets.end(); ++it)
- ensurePseudoInvalidationSet(static_cast<CSSSelector::PseudoType>(it->key)).combine(*it->value);
+ for (const auto& invalidationSet : other.m_classInvalidationSets)
+ ensureClassInvalidationSet(invalidationSet.key).combine(*invalidationSet.value);
+ for (const auto& invalidationSet : other.m_attributeInvalidationSets)
+ ensureAttributeInvalidationSet(invalidationSet.key).combine(*invalidationSet.value);
+ for (const auto& invalidationSet : other.m_idInvalidationSets)
+ ensureIdInvalidationSet(invalidationSet.key).combine(*invalidationSet.value);
+ for (const auto& invalidationSet : other.m_pseudoInvalidationSets)
+ ensurePseudoInvalidationSet(static_cast<CSSSelector::PseudoType>(invalidationSet.key)).combine(*invalidationSet.value);
m_metadata.add(other.m_metadata);
« no previous file with comments | « no previous file | Source/core/css/invalidation/DescendantInvalidationSet.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698