Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(640)

Unified Diff: Source/core/css/invalidation/StyleInvalidator.cpp

Issue 633343002: Use C++11 range based iteration for invalidation sets. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Review issue: renamed variables Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/css/invalidation/DescendantInvalidationSet.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/css/invalidation/StyleInvalidator.cpp
diff --git a/Source/core/css/invalidation/StyleInvalidator.cpp b/Source/core/css/invalidation/StyleInvalidator.cpp
index cefc3d7b17650398f523f56d1e6adc0d4ec46b8d..69f720f1171c5bf30d975cfd01b23abf6aea03f0 100644
--- a/Source/core/css/invalidation/StyleInvalidator.cpp
+++ b/Source/core/css/invalidation/StyleInvalidator.cpp
@@ -89,8 +89,8 @@ bool StyleInvalidator::RecursionData::matchesCurrentInvalidationSets(Element& el
if (m_invalidateCustomPseudo && element.shadowPseudoId() != nullAtom)
return true;
- for (InvalidationSets::iterator it = m_invalidationSets.begin(); it != m_invalidationSets.end(); ++it) {
- if ((*it)->invalidatesElement(element))
+ for (const auto& invalidationSet : m_invalidationSets) {
+ if (invalidationSet->invalidatesElement(element))
return true;
}
@@ -105,8 +105,8 @@ bool StyleInvalidator::checkInvalidationSetsAgainstElement(Element& element, Sty
}
if (element.needsStyleInvalidation()) {
if (InvalidationList* invalidationList = m_pendingInvalidationMap.get(&element)) {
- for (InvalidationList::const_iterator it = invalidationList->begin(); it != invalidationList->end(); ++it)
- recursionData.pushInvalidationSet(**it);
+ for (const auto& invalidationSet : *invalidationList)
+ recursionData.pushInvalidationSet(*invalidationSet);
// FIXME: It's really only necessary to clone the render style for this element, not full style recalc.
return true;
}
« no previous file with comments | « Source/core/css/invalidation/DescendantInvalidationSet.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698