Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 631823003: replace OVERRIDE and FINAL with override and final in storage/ (Closed)

Created:
6 years, 2 months ago by Mostyn Bramley-Moore
Modified:
6 years, 2 months ago
Reviewers:
danakj, dcheng
CC:
chromium-reviews, dcheng, kinuko+fileapi, nhiroki, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

replace OVERRIDE and FINAL with override and final in storage/ R=danakj@chromium.org,dcheng@chromium.org BUG=417463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -272 lines) Patch
M storage/browser/blob/blob_url_request_job.h View 1 chunk +7 lines, -7 lines 0 comments Download
M storage/browser/blob/blob_url_request_job_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/blob/local_file_stream_reader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/blob/view_blob_internals_job.h View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/database/database_quota_client.h View 1 chunk +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/async_file_util_adapter.h View 1 chunk +14 lines, -14 lines 0 comments Download
M storage/browser/fileapi/copy_or_move_operation_delegate.h View 1 chunk +6 lines, -6 lines 0 comments Download
M storage/browser/fileapi/copy_or_move_operation_delegate.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M storage/browser/fileapi/dragged_file_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/dragged_file_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/external_mount_points.h View 2 chunks +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/file_system_dir_url_request_job.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/file_system_file_stream_reader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/file_system_file_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_impl.h View 1 chunk +21 lines, -21 lines 0 comments Download
M storage/browser/fileapi/file_system_quota_client.h View 1 chunk +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/file_system_url_request_job.h View 1 chunk +8 lines, -8 lines 0 comments Download
M storage/browser/fileapi/file_system_url_request_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/file_writer_delegate.h View 1 chunk +6 lines, -6 lines 0 comments Download
M storage/browser/fileapi/isolated_context.h View 2 chunks +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/isolated_file_system_backend.h View 1 chunk +15 lines, -15 lines 0 comments Download
M storage/browser/fileapi/local_file_stream_writer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M storage/browser/fileapi/local_file_util.h View 1 chunk +13 lines, -13 lines 0 comments Download
M storage/browser/fileapi/local_file_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/native_file_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.h View 1 chunk +13 lines, -13 lines 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M storage/browser/fileapi/plugin_private_file_system_backend.h View 1 chunk +20 lines, -20 lines 0 comments Download
M storage/browser/fileapi/quota/quota_backend_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/remove_operation_delegate.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_stream_writer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend.h View 1 chunk +15 lines, -15 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend_delegate.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/sandbox_isolated_origin_database.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_origin_database.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_prioritized_origin_database.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_quota_observer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/transient_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/quota/quota_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M storage/browser/quota/quota_manager.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M storage/browser/quota/usage_tracker.h View 1 chunk +3 lines, -3 lines 0 comments Download

Dependent Patchsets:

Issue 1398473005 Patch 1
Issue 1430183002 Patch 1
Issue 1854043002 Patch 1

Messages

Total messages: 3 (0 generated)
Mostyn Bramley-Moore
@danakj: can you please give this a thumbs-up too?
6 years, 2 months ago (2014-10-06 14:09:41 UTC) #1
danakj
LGTM
6 years, 2 months ago (2014-10-06 15:26:54 UTC) #2
Mostyn Bramley-Moore
6 years, 2 months ago (2014-10-08 12:36:52 UTC) #3 
Obsoleted by https://codereview.chromium.org/624063003 - closing this.

Powered by Google App Engine
This is Rietveld 408576698