Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1398473005: be more explicit about gconf and glib conditions in net/BUILD.gn (Closed)

Created:
5 years, 2 months ago by Mostyn Bramley-Moore
Modified:
5 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

be more explicit about gconf and glib conditions in net/BUILD.gn BUG=512899, 516899 Committed: https://crrev.com/bf5e6cc276b5dc1b1a43e2c59deadb4dc060b5ed Cr-Commit-Position: refs/heads/master@{#355257}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 631823003 Patch 1

Messages

Total messages: 16 (7 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398473005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398473005/1
5 years, 2 months ago (2015-10-10 16:26:06 UTC) #2
Mostyn Bramley-Moore
@brettw: PTAL
5 years, 2 months ago (2015-10-10 16:38:21 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-10 17:01:43 UTC) #6
Mostyn Bramley-Moore
@cbentzel: perhaps you can review this small build fix?
5 years, 2 months ago (2015-10-20 20:13:56 UTC) #9
brettw
lgtm, was out of office.
5 years, 2 months ago (2015-10-21 02:52:55 UTC) #11
Mostyn Bramley-Moore
Thanks.
5 years, 2 months ago (2015-10-21 07:25:21 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1398473005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1398473005/1
5 years, 2 months ago (2015-10-21 07:26:02 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-21 07:53:38 UTC) #15
commit-bot: I haz the power
5 years, 2 months ago (2015-10-21 07:54:28 UTC) #16
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/bf5e6cc276b5dc1b1a43e2c59deadb4dc060b5ed
Cr-Commit-Position: refs/heads/master@{#355257}

Powered by Google App Engine
This is Rietveld 408576698