Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1854043002: convert //headless to std::unique_ptr (Closed)

Created:
4 years, 8 months ago by Mostyn Bramley-Moore
Modified:
4 years, 8 months ago
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

convert //headless to std::unique_ptr BUG=554298 Committed: https://crrev.com/c3d183bef609f3c4dab124572281ba13257d37a6 Cr-Commit-Position: refs/heads/master@{#384880}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -70 lines) Patch
M headless/app/headless_shell.cc View 2 chunks +3 lines, -1 line 0 comments Download
M headless/lib/browser/headless_browser_context.h View 3 chunks +4 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_browser_context.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.h View 3 chunks +4 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_browser_impl.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_browser_main_parts.h View 2 chunks +5 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_content_browser_client.cc View 2 chunks +5 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_devtools.h View 2 chunks +2 lines, -2 lines 0 comments Download
M headless/lib/browser/headless_devtools.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.h View 3 chunks +9 lines, -8 lines 0 comments Download
M headless/lib/browser/headless_url_request_context_getter.cc View 7 chunks +21 lines, -19 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M headless/lib/browser/headless_web_contents_impl.cc View 2 chunks +2 lines, -1 line 0 comments Download
M headless/lib/headless_browser_browsertest.cc View 3 chunks +4 lines, -2 lines 0 comments Download
M headless/lib/headless_content_main_delegate.h View 3 chunks +8 lines, -6 lines 0 comments Download
M headless/lib/headless_content_main_delegate.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M headless/lib/headless_web_contents_browsertest.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M headless/public/headless_browser.h View 2 chunks +2 lines, -2 lines 0 comments Download
M headless/test/headless_test_launcher.cc View 2 chunks +3 lines, -1 line 0 comments Download

Depends on Patchset:

Issue 631823003 Patch 1

Messages

Total messages: 12 (5 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854043002/1
4 years, 8 months ago (2016-04-03 18:40:16 UTC) #2
Mostyn Bramley-Moore
@Alex: please take a look.
4 years, 8 months ago (2016-04-03 19:09:30 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-03 19:11:44 UTC) #6
alex clarke (OOO till 29th)
lgtm
4 years, 8 months ago (2016-04-04 10:06:59 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1854043002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1854043002/1
4 years, 8 months ago (2016-04-04 10:57:46 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-04 11:02:54 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-04 11:04:02 UTC) #12
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/c3d183bef609f3c4dab124572281ba13257d37a6
Cr-Commit-Position: refs/heads/master@{#384880}

Powered by Google App Engine
This is Rietveld 408576698