Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 624063003: Replacing the OVERRIDE with override and FINAL with final in storage (Closed)

Created:
6 years, 2 months ago by MRV
Modified:
6 years, 2 months ago
Reviewers:
michaeln, michaeln1
CC:
chromium-reviews, Mostyn Bramley-Moore
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Replacing the OVERRIDE with override and FINAL with final in storage This step is a giant search and replace for OVERRIDE and FINAL to replace them with their lowercase versions. BUG=417463 Committed: https://crrev.com/8b6fef4be51145bbf28918f361242e26c563d45a Cr-Commit-Position: refs/heads/master@{#298376}

Patch Set 1 #

Patch Set 2 : Fixed the error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+272 lines, -272 lines) Patch
M storage/browser/blob/blob_url_request_job.h View 1 chunk +7 lines, -7 lines 0 comments Download
M storage/browser/blob/blob_url_request_job_factory.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/blob/local_file_stream_reader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/blob/view_blob_internals_job.h View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/database/database_quota_client.h View 1 chunk +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/async_file_util_adapter.h View 1 chunk +14 lines, -14 lines 0 comments Download
M storage/browser/fileapi/copy_or_move_operation_delegate.h View 1 chunk +6 lines, -6 lines 0 comments Download
M storage/browser/fileapi/copy_or_move_operation_delegate.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M storage/browser/fileapi/dragged_file_util.h View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/dragged_file_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/external_mount_points.h View 2 chunks +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/file_system_dir_url_request_job.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/file_system_file_stream_reader.h View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/file_system_file_util.h View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/file_system_operation_impl.h View 1 chunk +21 lines, -21 lines 0 comments Download
M storage/browser/fileapi/file_system_quota_client.h View 1 chunk +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/file_system_url_request_job.h View 1 chunk +8 lines, -8 lines 0 comments Download
M storage/browser/fileapi/file_system_url_request_job_factory.cc View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/fileapi/file_writer_delegate.h View 1 chunk +6 lines, -6 lines 0 comments Download
M storage/browser/fileapi/isolated_context.h View 2 chunks +7 lines, -7 lines 0 comments Download
M storage/browser/fileapi/isolated_file_system_backend.h View 1 chunk +15 lines, -15 lines 0 comments Download
M storage/browser/fileapi/local_file_stream_writer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M storage/browser/fileapi/local_file_util.h View 1 chunk +13 lines, -13 lines 0 comments Download
M storage/browser/fileapi/local_file_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/native_file_util.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.h View 1 chunk +13 lines, -13 lines 0 comments Download
M storage/browser/fileapi/obfuscated_file_util.cc View 4 chunks +6 lines, -6 lines 0 comments Download
M storage/browser/fileapi/plugin_private_file_system_backend.h View 1 chunk +20 lines, -20 lines 0 comments Download
M storage/browser/fileapi/quota/quota_backend_impl.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/remove_operation_delegate.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_stream_writer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend.h View 1 chunk +15 lines, -15 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend_delegate.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_file_system_backend_delegate.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M storage/browser/fileapi/sandbox_isolated_origin_database.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_origin_database.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_prioritized_origin_database.h View 1 chunk +5 lines, -5 lines 0 comments Download
M storage/browser/fileapi/sandbox_quota_observer.h View 1 chunk +4 lines, -4 lines 0 comments Download
M storage/browser/fileapi/transient_file_util.h View 1 chunk +1 line, -1 line 0 comments Download
M storage/browser/quota/quota_manager.h View 1 chunk +3 lines, -3 lines 0 comments Download
M storage/browser/quota/quota_manager.cc View 9 chunks +12 lines, -12 lines 0 comments Download
M storage/browser/quota/usage_tracker.h View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
MRV
PTAL
6 years, 2 months ago (2014-10-06 13:58:50 UTC) #2
MRV
On 2014/10/06 13:58:50, MRV wrote: > PTAL Dear mr. michaeln PTAL
6 years, 2 months ago (2014-10-06 16:17:11 UTC) #3
michaeln1
lgtm
6 years, 2 months ago (2014-10-06 19:41:34 UTC) #4
michaeln
and lgtm too
6 years, 2 months ago (2014-10-06 19:42:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624063003/20001
6 years, 2 months ago (2014-10-07 00:47:07 UTC) #7
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 2 months ago (2014-10-07 02:51:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/624063003/20001
6 years, 2 months ago (2014-10-07 03:11:01 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 3ba9c21ae9c12325add272ae742c1de875d1bc6b
6 years, 2 months ago (2014-10-07 04:56:48 UTC) #12
commit-bot: I haz the power
6 years, 2 months ago (2014-10-07 04:57:34 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8b6fef4be51145bbf28918f361242e26c563d45a
Cr-Commit-Position: refs/heads/master@{#298376}

Powered by Google App Engine
This is Rietveld 408576698