Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 629073003: Simplify/cleanup {postApply,apply}Resource signatures (Closed)

Created:
6 years, 2 months ago by fs
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Simplify/cleanup {postApply,apply}Resource signatures With the scope of this interface reduced, one argument to postApplyResource can be removed, and the GraphicsContext*& can be simplified to GraphicsContext*. Also change "unsigned short resourceMode" to RenderSVGResourceModeFlags while we're changing all signatures. BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183273

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M Source/core/rendering/svg/RenderSVGResource.h View 1 chunk +2 lines, -2 lines 3 comments Download
M Source/core/rendering/svg/RenderSVGResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceGradient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceSolidColor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceSolidColor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (2 generated)
fs
6 years, 2 months ago (2014-10-06 13:49:57 UTC) #2
f(malita)
Thanks for cleaning this up! https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/RenderSVGResource.h File Source/core/rendering/svg/RenderSVGResource.h (right): https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/RenderSVGResource.h#newcode57 Source/core/rendering/svg/RenderSVGResource.h:57: virtual bool applyResource(RenderObject*, RenderStyle*, ...
6 years, 2 months ago (2014-10-06 14:21:41 UTC) #3
fs
https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/RenderSVGResource.h File Source/core/rendering/svg/RenderSVGResource.h (right): https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/RenderSVGResource.h#newcode57 Source/core/rendering/svg/RenderSVGResource.h:57: virtual bool applyResource(RenderObject*, RenderStyle*, GraphicsContext*, RenderSVGResourceModeFlags); On 2014/10/06 14:21:41, ...
6 years, 2 months ago (2014-10-06 14:34:48 UTC) #4
f(malita)
On 2014/10/06 14:34:48, fs wrote: > https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/RenderSVGResource.h > File Source/core/rendering/svg/RenderSVGResource.h (right): > > https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/RenderSVGResource.h#newcode57 > ...
6 years, 2 months ago (2014-10-06 14:51:38 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/629073003/1
6 years, 2 months ago (2014-10-06 14:57:05 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183273
6 years, 2 months ago (2014-10-06 15:00:53 UTC) #8
ccameron
On 2014/10/06 15:00:53, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 2 months ago (2014-10-06 19:11:22 UTC) #9
f(malita)
On 2014/10/06 19:11:22, ccameron1 wrote: > On 2014/10/06 15:00:53, I haz the power (commit-bot) wrote: ...
6 years, 2 months ago (2014-10-06 19:13:17 UTC) #10
ccameron
6 years, 2 months ago (2014-10-06 19:14:07 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/636623002/ by ccameron@chromium.org.

The reason for reverting is: Reverting because of failures in maps_pixel_tests

https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.8%20Release%20(In...

https://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20(Intel)/bu....

Powered by Google App Engine
This is Rietveld 408576698