Simplify/cleanup {postApply,apply}Resource signatures

Simplify/cleanup {postApply,apply}Resource signatures

With the scope of this interface reduced, one argument to
postApplyResource can be removed, and the GraphicsContext*& can be
simplified to GraphicsContext*. Also change "unsigned short resourceMode"
to RenderSVGResourceModeFlags while we're changing all signatures.

BUG=420022
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183273

[fs, 2014-10-06 13:49:56]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org, schenney@chromium.org

[f(malita), 2014-10-06 14:21:41]

Thanks for cleaning this up!

https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/Re...
File Source/core/rendering/svg/RenderSVGResource.h (right):

https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/RenderSVGResource.h:57: virtual bool
applyResource(RenderObject*, RenderStyle*, GraphicsContext*,
RenderSVGResourceModeFlags);
We can make this pure virtual and drop the stub impl (RenderSVGResource is
abstract already).

https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/RenderSVGResource.h:58: virtual void
postApplyResource(GraphicsContext*) { }
For symmetry, we can also make this pure virtual (only
RenderSVGResourceSolidColor doesn't override IINM).

[fs, 2014-10-06 14:34:48]

https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/Re...
File Source/core/rendering/svg/RenderSVGResource.h (right):

https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/Re...
Source/core/rendering/svg/RenderSVGResource.h:57: virtual bool
applyResource(RenderObject*, RenderStyle*, GraphicsContext*,
RenderSVGResourceModeFlags);
On 2014/10/06 14:21:41, Florin Malita wrote:
> We can make this pure virtual and drop the stub impl (RenderSVGResource is
> abstract already).

No - not yet at least - since we still have Clipper/Masker/etc. in this
hierarchy, and hence they need something non-abstract. Ditto for the post*
(which I'm ~3 CLs away from removing though...)

[f(malita), 2014-10-06 14:51:38]

On 2014/10/06 14:34:48, fs wrote:
>
https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/Re...
> File Source/core/rendering/svg/RenderSVGResource.h (right):
> 
>
https://codereview.chromium.org/629073003/diff/1/Source/core/rendering/svg/Re...
> Source/core/rendering/svg/RenderSVGResource.h:57: virtual bool
> applyResource(RenderObject*, RenderStyle*, GraphicsContext*,
> RenderSVGResourceModeFlags);
> On 2014/10/06 14:21:41, Florin Malita wrote:
> > We can make this pure virtual and drop the stub impl (RenderSVGResource is
> > abstract already).
> 
> No - not yet at least - since we still have Clipper/Masker/etc. in this
> hierarchy, and hence they need something non-abstract. Ditto for the post*
> (which I'm ~3 CLs away from removing though...)

LGTM.

[fs, 2014-10-06 14:56:33]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2014-10-06 14:57:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/629073003/1

[commit-bot: I haz the power, 2014-10-06 15:00:53]

Committed patchset #1 (id:1) as 183273

[ccameron, 2014-10-06 19:11:22]

On 2014/10/06 15:00:53, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as 183273

I'm seeing lots of failures on maps pixel tests around when this came in:
https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.8%20Release%20(In...

Planning to revert this

[f(malita), 2014-10-06 19:13:17]

On 2014/10/06 19:11:22, ccameron1 wrote:
> On 2014/10/06 15:00:53, I haz the power (commit-bot) wrote:
> > Committed patchset #1 (id:1) as 183273
> 
> I'm seeing lots of failures on maps pixel tests around when this came in:
>
https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.8%20Release%20(In...
> 
> Planning to revert this

ERROR             net(643): Timeout while reading from
https://isolateserver.appspot.com/content-gs/retrieve/default-gzip/e8664e83a4...,
read 21692416 of 50511318: The read operation timed out
ERROR   isolateserver(577): Failed to fetch
e8664e83a48dde1da4d2385c299ea70f20e1cd8f: The read operation timed out

Highly unlikely to be related.

[ccameron, 2014-10-06 19:14:07]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/636623002/ by ccameron@chromium.org.

The reason for reverting is: Reverting because of failures in maps_pixel_tests

https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.8%20Release%20(In...

https://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20(Intel)/bu....