Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 636623002: Revert of Simplify/cleanup {postApply,apply}Resource signatures (Closed)

Created:
6 years, 2 months ago by ccameron
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-rendering, zoltan1, rwlbuis, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, gyuyoung.kim_webkit.org, jchaffraix+rendering, Stephen Chennney, pdr+svgwatchlist_chromium.org, rune+blink
Project:
blink
Visibility:
Public.

Description

Revert of Simplify/cleanup {postApply,apply}Resource signatures (patchset #1 id:1 of https://codereview.chromium.org/629073003/) Reason for revert: Reverting because of failures in maps_pixel_tests https://build.chromium.org/p/chromium.gpu/builders/Mac%2010.8%20Release%20(Intel)/builds/29281 https://build.chromium.org/p/chromium.gpu/builders/Mac%20Release%20(Intel)/builds/41229 Original issue's description: > Simplify/cleanup {postApply,apply}Resource signatures > > With the scope of this interface reduced, one argument to > postApplyResource can be removed, and the GraphicsContext*& can be > simplified to GraphicsContext*. Also change "unsigned short resourceMode" > to RenderSVGResourceModeFlags while we're changing all signatures. > > BUG=420022 > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183273 TBR=pdr@chromium.org,fmalita@chromium.org,schenney@chromium.org,fs@opera.com NOTREECHECKS=true NOTRY=true BUG=420022 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183284

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -18 lines) Patch
M Source/core/rendering/svg/RenderSVGResource.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceGradient.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceGradient.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourcePattern.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceSolidColor.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceSolidColor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGShape.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/svg/SVGInlineTextBox.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
ccameron
Created Revert of Simplify/cleanup {postApply,apply}Resource signatures
6 years, 2 months ago (2014-10-06 19:14:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/636623002/1
6 years, 2 months ago (2014-10-06 19:14:43 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 183284
6 years, 2 months ago (2014-10-06 19:15:55 UTC) #3
f(malita)
6 years, 2 months ago (2014-10-06 19:27:14 UTC) #4
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/636643002/ by fmalita@chromium.org.

The reason for reverting is: The maps_pixel_tests failures are unrelated..

Powered by Google App Engine
This is Rietveld 408576698