Simplify/cleanup {postApply,apply}Resource signatures

Source/core/rendering/svg/RenderSVGResource.h

 /*
  * Copyright (C) Research In Motion Limited 2009-2010. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
  * This library is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 36 matching lines @@
 class RenderSVGResourceSolidColor;
 
 class RenderSVGResource {
 public:
     RenderSVGResource() { }
     virtual ~RenderSVGResource() { }
 
     virtual void removeAllClientsFromCache(bool markForInvalidation = true) = 0;
     virtual void removeClientFromCache(RenderObject*, bool markForInvalidation = true) = 0;
 
-    virtual bool applyResource(RenderObject*, RenderStyle*, GraphicsContext*&, unsigned short resourceMode);
-    virtual void postApplyResource(RenderObject*, GraphicsContext*&) { }
+    virtual bool applyResource(RenderObject*, RenderStyle*, GraphicsContext*, RenderSVGResourceModeFlags);

[f(malita), 2014/10/06 14:21:41]

We can make this pure virtual and drop the stub impl (RenderSVGResource is
abstract already).

[fs, 2014/10/06 14:34:48]

No - not yet at least - since we still have Clipper/Masker/etc. in this
hierarchy, and hence they need something non-abstract. Ditto for the post*
(which I'm ~3 CLs away from removing though...)

+    virtual void postApplyResource(GraphicsContext*) { }

[f(malita), 2014/10/06 14:21:41]

For symmetry, we can also make this pure virtual (only
RenderSVGResourceSolidColor doesn't override IINM).

 
     virtual RenderSVGResourceType resourceType() const = 0;
 
     template<class Renderer>
     Renderer* cast()
     {
         if (Renderer::s_resourceType == resourceType())
             return static_cast<Renderer*>(this);
 
         return 0;
     }
 
     // Helper utilities used in the render tree to access resources used for painting shapes/text (gradients & patterns & solid colors only)
     // If hasFallback gets set to true, the sharedSolidPaintingResource is set to a fallback color.
     static RenderSVGResource* requestPaintingResource(RenderSVGResourceMode, RenderObject*, const RenderStyle*, bool& hasFallback);
     static RenderSVGResourceSolidColor* sharedSolidPaintingResource();
 
     static void markForLayoutAndParentResourceInvalidation(RenderObject*, bool needsLayout = true);
 };
 
 #define DEFINE_RENDER_SVG_RESOURCE_TYPE_CASTS(thisType, typeName) \
     DEFINE_TYPE_CASTS(thisType, RenderSVGResource, resource, resource->resourceType() == typeName, resource.resourceType() == typeName)
 
 }
 
 #endif