replace OVERRIDE and FINAL with override and final in net/

replace OVERRIDE and FINAL with override and final in net/

BUG=417463
Committed: https://crrev.com/ba063d6038f4e0df5188cdd46589c62388d8e06b
Cr-Commit-Position: refs/heads/master@{#298844}

[Mostyn Bramley-Moore, 2014-10-04 08:04:19]

@Paul: can you give this a thumbs-up?

The script I used to make this change is mentioned in the comments over here:
https://codereview.chromium.org/614103004/

[Mostyn Bramley-Moore, 2014-10-08 19:15:34]

mostynb@opera.com changed reviewers:
+ rdsmith@chromium.org

[Mostyn Bramley-Moore, 2014-10-08 19:16:58]

...adding another net/OWNER

@rdsmith: can you please take a look at this?

[Randy Smith (Not in Mondays), 2014-10-08 19:29:55]

I'd like a stamp from dcheng@ as well just to confirm that this approach is ok
(I skimmed the referred CL but there's a lot of discussion there and no stamp),
but I'll stamp LGTM conditional on dcheng@'s LGTM.

[dcheng, 2014-10-08 20:25:47]

https://codereview.chromium.org/623213004/diff/10001/net/base/escape.cc
File net/base/escape.cc (right):

https://codereview.chromium.org/623213004/diff/10001/net/base/escape.cc#newco...
net/base/escape.cc:164: // U+202E RIGHT-TO-LEFT override     (%E2%80%AE)
These look like incorrect replacements.

[Mostyn Bramley-Moore, 2014-10-08 20:48:31]

https://codereview.chromium.org/623213004/diff/10001/net/base/escape.cc
File net/base/escape.cc (right):

https://codereview.chromium.org/623213004/diff/10001/net/base/escape.cc#newco...
net/base/escape.cc:164: // U+202E RIGHT-TO-LEFT override     (%E2%80%AE)
On 2014/10/08 20:25:47, dcheng wrote:
> These look like incorrect replacements.

Fixed in patchset 3.

My cpp based cross-check didn't find this difference to the sed based method
used here because the -traditional-cpp flag I use to preserve whitespace
switches to C mode, which doesn't treat C++ style comments as comments. 
Unfortunately -traditional-cpp -x c++ doesn't preserve whitespace in the way
that I want :/

[dcheng, 2014-10-08 21:01:24]

LGTM.

We can probably get 99% of the way there if we use perl instead of sed and do a
lookbehind assertion that there's a ) somewhere on the line. I don't know if
it's worth the complexity at this point.

[Mostyn Bramley-Moore, 2014-10-08 21:11:13]

On 2014/10/08 21:01:24, dcheng wrote:
> LGTM.
> 
> We can probably get 99% of the way there if we use perl instead of sed and do
a
> lookbehind assertion that there's a ) somewhere on the line. I don't know if
> it's worth the complexity at this point.

That might not work for multiline prototypes, but the diff between the plain sed
method and sed with ) earlier on the line is probably small enough to check
manually.

[Mostyn Bramley-Moore, 2014-10-08 21:11:30]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2014-10-08 21:16:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/623213004/20001

[dcheng, 2014-10-08 21:44:10]

On 2014/10/08 at 21:11:13, mostynb wrote:
> On 2014/10/08 21:01:24, dcheng wrote:
> > LGTM.
> > 
> > We can probably get 99% of the way there if we use perl instead of sed and
do a
> > lookbehind assertion that there's a ) somewhere on the line. I don't know if
> > it's worth the complexity at this point.
> 
> That might not work for multiline prototypes, but the diff between the plain
sed method and sed with ) earlier on the line is probably small enough to check
manually.

clang-format tries to keep override/final on the same line as the last
parameter. There was a period of time when it was handling it incorrectly, but
it should be fixed now. So instances of this should be pretty rare.

[commit-bot: I haz the power, 2014-10-09 02:59:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-10-09 02:59:49]

Exceeded time limit waiting for builds to trigger.

[Mostyn Bramley-Moore, 2014-10-09 06:03:36]

The CQ bit was checked by mostynb@opera.com

[commit-bot: I haz the power, 2014-10-09 06:05:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/623213004/20001

[commit-bot: I haz the power, 2014-10-09 11:01:32]

Committed patchset #3 (id:20001) as 0ec3af738aa6202499e5ec00da31c5264c355359

[commit-bot: I haz the power, 2014-10-09 11:02:23]

Patchset 3 (id:??) landed as
https://crrev.com/ba063d6038f4e0df5188cdd46589c62388d8e06b
Cr-Commit-Position: refs/heads/master@{#298844}