Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Side by Side Diff: net/cert/cert_verify_proc_unittest.cc

Issue 623213004: replace OVERRIDE and FINAL with override and final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: undo unwanted change in comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/cert/cert_verify_proc_openssl.h ('k') | net/cert/cert_verify_proc_win.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/cert_verify_proc.h" 5 #include "net/cert/cert_verify_proc.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/callback_helpers.h" 9 #include "base/callback_helpers.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 40 matching lines...) Expand 10 before | Expand all | Expand 10 after
51 // Mock CertVerifyProc that will set |verify_result->is_issued_by_known_root| 51 // Mock CertVerifyProc that will set |verify_result->is_issued_by_known_root|
52 // for all certificates that are Verified. 52 // for all certificates that are Verified.
53 class WellKnownCaCertVerifyProc : public CertVerifyProc { 53 class WellKnownCaCertVerifyProc : public CertVerifyProc {
54 public: 54 public:
55 // Initialize a CertVerifyProc that will set 55 // Initialize a CertVerifyProc that will set
56 // |verify_result->is_issued_by_known_root| to |is_well_known|. 56 // |verify_result->is_issued_by_known_root| to |is_well_known|.
57 explicit WellKnownCaCertVerifyProc(bool is_well_known) 57 explicit WellKnownCaCertVerifyProc(bool is_well_known)
58 : is_well_known_(is_well_known) {} 58 : is_well_known_(is_well_known) {}
59 59
60 // CertVerifyProc implementation: 60 // CertVerifyProc implementation:
61 virtual bool SupportsAdditionalTrustAnchors() const OVERRIDE { return false; } 61 virtual bool SupportsAdditionalTrustAnchors() const override { return false; }
62 62
63 protected: 63 protected:
64 virtual ~WellKnownCaCertVerifyProc() {} 64 virtual ~WellKnownCaCertVerifyProc() {}
65 65
66 private: 66 private:
67 virtual int VerifyInternal(X509Certificate* cert, 67 virtual int VerifyInternal(X509Certificate* cert,
68 const std::string& hostname, 68 const std::string& hostname,
69 int flags, 69 int flags,
70 CRLSet* crl_set, 70 CRLSet* crl_set,
71 const CertificateList& additional_trust_anchors, 71 const CertificateList& additional_trust_anchors,
72 CertVerifyResult* verify_result) OVERRIDE; 72 CertVerifyResult* verify_result) override;
73 73
74 const bool is_well_known_; 74 const bool is_well_known_;
75 75
76 DISALLOW_COPY_AND_ASSIGN(WellKnownCaCertVerifyProc); 76 DISALLOW_COPY_AND_ASSIGN(WellKnownCaCertVerifyProc);
77 }; 77 };
78 78
79 int WellKnownCaCertVerifyProc::VerifyInternal( 79 int WellKnownCaCertVerifyProc::VerifyInternal(
80 X509Certificate* cert, 80 X509Certificate* cert,
81 const std::string& hostname, 81 const std::string& hostname,
82 int flags, 82 int flags,
(...skipping 1487 matching lines...) Expand 10 before | Expand all | Expand 10 after
1570 EXPECT_TRUE(verify_result.cert_status & CERT_STATUS_COMMON_NAME_INVALID); 1570 EXPECT_TRUE(verify_result.cert_status & CERT_STATUS_COMMON_NAME_INVALID);
1571 } 1571 }
1572 } 1572 }
1573 1573
1574 WRAPPED_INSTANTIATE_TEST_CASE_P( 1574 WRAPPED_INSTANTIATE_TEST_CASE_P(
1575 VerifyName, 1575 VerifyName,
1576 CertVerifyProcNameTest, 1576 CertVerifyProcNameTest,
1577 testing::ValuesIn(kVerifyNameData)); 1577 testing::ValuesIn(kVerifyNameData));
1578 1578
1579 } // namespace net 1579 } // namespace net
OLDNEW
« no previous file with comments | « net/cert/cert_verify_proc_openssl.h ('k') | net/cert/cert_verify_proc_win.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698