Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Side by Side Diff: net/cert/multi_log_ct_verifier_unittest.cc

Issue 623213004: replace OVERRIDE and FINAL with override and final in net/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: undo unwanted change in comment Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/cert/multi_log_ct_verifier.h ('k') | net/cert/multi_threaded_cert_verifier.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/multi_log_ct_verifier.h" 5 #include "net/cert/multi_log_ct_verifier.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/files/file_path.h" 9 #include "base/files/file_path.h"
10 #include "base/files/file_util.h" 10 #include "base/files/file_util.h"
(...skipping 19 matching lines...) Expand all
30 namespace net { 30 namespace net {
31 31
32 namespace { 32 namespace {
33 33
34 const char kLogDescription[] = "somelog"; 34 const char kLogDescription[] = "somelog";
35 const char kSCTCountHistogram[] = 35 const char kSCTCountHistogram[] =
36 "Net.CertificateTransparency.SCTsPerConnection"; 36 "Net.CertificateTransparency.SCTsPerConnection";
37 37
38 class MultiLogCTVerifierTest : public ::testing::Test { 38 class MultiLogCTVerifierTest : public ::testing::Test {
39 public: 39 public:
40 virtual void SetUp() OVERRIDE { 40 virtual void SetUp() override {
41 scoped_ptr<CTLogVerifier> log( 41 scoped_ptr<CTLogVerifier> log(
42 CTLogVerifier::Create(ct::GetTestPublicKey(), kLogDescription)); 42 CTLogVerifier::Create(ct::GetTestPublicKey(), kLogDescription));
43 ASSERT_TRUE(log); 43 ASSERT_TRUE(log);
44 44
45 verifier_.reset(new MultiLogCTVerifier()); 45 verifier_.reset(new MultiLogCTVerifier());
46 verifier_->AddLog(log.Pass()); 46 verifier_->AddLog(log.Pass());
47 std::string der_test_cert(ct::GetDerEncodedX509Cert()); 47 std::string der_test_cert(ct::GetDerEncodedX509Cert());
48 chain_ = X509Certificate::CreateFromBytes( 48 chain_ = X509Certificate::CreateFromBytes(
49 der_test_cert.data(), 49 der_test_cert.data(),
50 der_test_cert.length()); 50 der_test_cert.length());
(...skipping 243 matching lines...) Expand 10 before | Expand all | Expand 10 after
294 TEST_F(MultiLogCTVerifierTest, CountsZeroSCTsCorrectly) { 294 TEST_F(MultiLogCTVerifierTest, CountsZeroSCTsCorrectly) {
295 int connections_without_scts = GetValueFromHistogram(kSCTCountHistogram, 0); 295 int connections_without_scts = GetValueFromHistogram(kSCTCountHistogram, 0);
296 EXPECT_FALSE(VerifySinglePrecertificateChain(chain_)); 296 EXPECT_FALSE(VerifySinglePrecertificateChain(chain_));
297 ASSERT_EQ(connections_without_scts + 1, 297 ASSERT_EQ(connections_without_scts + 1,
298 GetValueFromHistogram(kSCTCountHistogram, 0)); 298 GetValueFromHistogram(kSCTCountHistogram, 0));
299 } 299 }
300 300
301 } // namespace 301 } // namespace
302 302
303 } // namespace net 303 } // namespace net
OLDNEW
« no previous file with comments | « net/cert/multi_log_ct_verifier.h ('k') | net/cert/multi_threaded_cert_verifier.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698