Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(14)

Issue 622733002: ScriptPromiseResolver leaked resource when constructed on stopped context. (Closed)

Created:
6 years, 2 months ago by yhirano
Modified:
6 years, 2 months ago
CC:
blink-reviews, blink-reviews-bindings_chromium.org, arv+blink, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

ScriptPromiseResolver leaked resource when constructed on stopped context. ScriptPromiseResolver stops working when the associated ExecutionContext is stopped. ScriptPromiseResolver can be constructed on a stopped ExecutionContext. In such a case the constructed resolver is stopped as well. Moreover, it should release the created (internal) resolver not to leak resource. BUG=385384 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183123

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -15 lines) Patch
M LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html View 1 2 1 chunk +4 lines, -7 lines 0 comments Download
M LayoutTests/webmidi/requestmidiaccess-in-detached-frame-expected.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download
M Source/bindings/core/v8/ScriptPromiseResolver.cpp View 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/battery/BatteryManager.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M Source/modules/webmidi/NavigatorWebMIDI.cpp View 1 2 chunks +2 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
yhirano
I removed sof's workaround as it isn't needed any more.
6 years, 2 months ago (2014-10-02 02:24:22 UTC) #2
yhirano
On 2014/10/02 02:24:22, yhirano wrote: > I removed sof's workaround as it isn't needed any ...
6 years, 2 months ago (2014-10-02 02:26:19 UTC) #3
haraken
LGTM, this fix makes a lot of more sense!
6 years, 2 months ago (2014-10-02 02:35:17 UTC) #4
yhirano
This change breaks a WebMIDI test. toyoshim@, can you review the WebMIDI change?
6 years, 2 months ago (2014-10-02 03:47:08 UTC) #6
Takashi Toyoshima
LGTM. It does not break the test, but fixes behavior correctly:)
6 years, 2 months ago (2014-10-02 03:59:09 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622733002/40001
6 years, 2 months ago (2014-10-02 06:46:21 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/29833)
6 years, 2 months ago (2014-10-02 07:59:23 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622733002/40001
6 years, 2 months ago (2014-10-02 08:02:07 UTC) #13
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 08:35:51 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as 183123

Powered by Google App Engine
This is Rietveld 408576698