Source/bindings/core/v8/ScriptPromiseResolver.cpp - Issue 622733002: ScriptPromiseResolver leaked resource when constructed on stopped context.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptPromiseResolver.cpp

Issue 622733002: ScriptPromiseResolver leaked resource when constructed on stopped context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/webmidi/requestmidiaccess-in-detached-frame-expected.txt ('k') | Source/modules/battery/BatteryManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/core/v8/ScriptPromiseResolver.cpp

diff --git a/Source/bindings/core/v8/ScriptPromiseResolver.cpp b/Source/bindings/core/v8/ScriptPromiseResolver.cpp

index 2e2f7be95ccc5028fb55aa2c270db0724cbefee8..2f11b0d6cab9d80a39d25b3c1a0765ea113fefeb 100644

--- a/Source/bindings/core/v8/ScriptPromiseResolver.cpp

+++ b/Source/bindings/core/v8/ScriptPromiseResolver.cpp

@@ -20,8 +20,10 @@ ScriptPromiseResolver::ScriptPromiseResolver(ScriptState* scriptState)

, m_isPromiseCalled(false)

#endif

{

- if (executionContext()->activeDOMObjectsAreStopped())

+ if (executionContext()->activeDOMObjectsAreStopped()) {

m_state = ResolvedOrRejected;

+ m_resolver.clear();

+ }

}

void ScriptPromiseResolver::suspend()

« no previous file with comments | « LayoutTests/webmidi/requestmidiaccess-in-detached-frame-expected.txt ('k') | Source/modules/battery/BatteryManager.cpp » ('j') | no next file with comments »