Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html

Issue 622733002: ScriptPromiseResolver leaked resource when constructed on stopped context. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | LayoutTests/webmidi/requestmidiaccess-in-detached-frame-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html
diff --git a/LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html b/LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html
index 47273b629dac451a1062547b7038f139afb51278..dbe30c220ca902cd13e6146ba769214faf1896fe 100644
--- a/LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html
+++ b/LayoutTests/webmidi/requestmidiaccess-in-detached-frame.html
@@ -13,19 +13,16 @@ document.body.appendChild(iframe);
contentNavigator = iframe.contentWindow.navigator;
document.body.removeChild(iframe);
-// set testRunner configuration so that requestMIDIAccess returns "InvalidStateError".
+// set testRunner configuration so that requestMIDIAccess returns "AbortError".
contentNavigator.requestMIDIAccess().then(function() {
testFailed("requestMIDIAccess() does not fail unexpectedly.");
finishJSTest();
-}, function() {
- errorName = error.name;
- shouldBe("errorName", "'InvalidStateError'");
+}, function(error) {
+ window.errorName = error.name;
+ shouldBeEqualToString("errorName", 'AbortError');
testPassed("requestMIDIAccess() fail as expected.");
finishJSTest();
});
-// FIXME: errorCallback should be called, but due to the Blink Promise impelementation the
-// returned Promise never be resolved nor rejected.
-finishJSTest();
</script>
</body>
« no previous file with comments | « no previous file | LayoutTests/webmidi/requestmidiaccess-in-detached-frame-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698