replace OVERRIDE and FINAL with override and final in extensions/

replace OVERRIDE and FINAL with override and final in extensions/

BUG=417463
Committed: https://crrev.com/0eac4e1becc07e32503722d9ffd421cf8c8688e3
Cr-Commit-Position: refs/heads/master@{#298042}

[Mostyn Bramley-Moore, 2014-10-03 13:40:14]

mostynb@opera.com changed reviewers:
+ dcheng@chromium.org, yoz@chromium.org

[Mostyn Bramley-Moore, 2014-10-03 13:41:03]

@yoz: can you give this a thumbs-up?

The script I used to make this change is mentioned in the comments over here:
https://codereview.chromium.org/614103004/

[Yoyo Zhou, 2014-10-03 15:20:08]

LGTM (you might have greater success with smaller patches than this, FYI; merge
conflicts are likely)

[Mostyn Bramley-Moore, 2014-10-03 15:33:40]

The CQ bit was checked by mostynb@opera.com

[Mostyn Bramley-Moore, 2014-10-03 15:34:36]

On 2014/10/03 15:20:08, Yoyo Zhou wrote:
> LGTM (you might have greater success with smaller patches than this, FYI;
merge
> conflicts are likely)

Thanks.

I have had a few conflicts in related CLs already, it's an unpleasant balancing
act between lots of CLs and lots of merge conflicts.

[commit-bot: I haz the power, 2014-10-03 15:35:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/622343002/1

[commit-bot: I haz the power, 2014-10-03 16:32:31]

Committed patchset #1 (id:1) as b33d79fabff31f37361b800b3ab32ddc63ba1403

[commit-bot: I haz the power, 2014-10-03 16:33:12]

Patchset 1 (id:??) landed as
https://crrev.com/0eac4e1becc07e32503722d9ffd421cf8c8688e3
Cr-Commit-Position: refs/heads/master@{#298042}

[please use gerrit instead, 2014-10-03 22:58:30]

Hi, this patch may have broken
RequestContentScriptAPITest.PermissionMatcherAgreementInjection on
https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)

If it continues to fail, I will be reverting this patch. If you don't hear from
me again, then everything is OK :-)

Here is the failure in question:

RequestContentScriptAPITest.PermissionMatcherAgreementInjection (run #1):
[ RUN      ] RequestContentScriptAPITest.PermissionMatcherAgreementInjection
[292:3616:1003/152731:WARNING:data_reduction_proxy_settings.cc(331)] SPDY proxy
OFF at startup
[2176:1200:1003/152735:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3620:4268:1003/152739:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3620:4072:1003/152740:ERROR:ipc_channel_win.cc(171)] pipe error: 109
[292:3660:1003/152740:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[292:4944:1003/152740:WARNING:embedded_test_server.cc(242)] Request not handled.
Returning 404: /favicon.ico
[2172:4520:1003/152744:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[292:3660:1003/152745:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[5024:3156:1003/152749:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[5024:1240:1003/152750:ERROR:ipc_channel_win.cc(460)] pipe error: 232
[292:3660:1003/152750:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[4036:4168:1003/152753:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[4036:2276:1003/152754:ERROR:ipc_channel_win.cc(460)] pipe error: 232
[292:3660:1003/152754:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[3400:4148:1003/152759:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3400:3816:1003/152800:ERROR:ipc_channel_win.cc(171)] pipe error: 109
[292:3660:1003/152800:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[4788:3804:1003/152804:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[4788:5040:1003/152806:ERROR:ipc_channel_win.cc(171)] pipe error: 109
[292:3660:1003/152806:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[2672:4216:1003/152810:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[292:3660:1003/152810:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[2684:4196:1003/152813:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[2684:1992:1003/152814:ERROR:ipc_channel_win.cc(171)] pipe error: 109
[292:3660:1003/152814:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue

RequestContentScriptAPITest.PermissionMatcherAgreementInjection (run #2):
[ RUN      ] RequestContentScriptAPITest.PermissionMatcherAgreementInjection
[2176:4956:1003/154428:WARNING:data_reduction_proxy_settings.cc(331)] SPDY proxy
OFF at startup
[4004:2712:1003/154432:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3940:1484:1003/154435:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3940:3508:1003/154437:ERROR:ipc_channel_win.cc(171)] pipe error: 109
[2176:4308:1003/154437:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[2176:4044:1003/154437:WARNING:embedded_test_server.cc(242)] Request not
handled. Returning 404: /favicon.ico
[3860:380:1003/154441:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[2176:4308:1003/154442:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[4540:2020:1003/154445:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[2176:4308:1003/154446:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[5080:4600:1003/154450:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[2176:4308:1003/154452:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[1768:2516:1003/154455:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[2176:4308:1003/154456:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[2796:2488:1003/154459:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[2796:4688:1003/154500:ERROR:ipc_channel_win.cc(460)] pipe error: 232
[2176:4308:1003/154500:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[1184:2328:1003/154503:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[2176:4308:1003/154504:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[4728:2420:1003/154507:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[2176:4308:1003/154508:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue

RequestContentScriptAPITest.PermissionMatcherAgreementInjection (run #3):
[ RUN      ] RequestContentScriptAPITest.PermissionMatcherAgreementInjection
[4364:2208:1003/154603:WARNING:data_reduction_proxy_settings.cc(331)] SPDY proxy
OFF at startup
[2020:2864:1003/154607:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[4428:4252:1003/154611:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[4364:2644:1003/154612:WARNING:embedded_test_server.cc(242)] Request not
handled. Returning 404: /favicon.ico
[4364:4336:1003/154612:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[1320:4688:1003/154616:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[1320:1832:1003/154617:ERROR:ipc_channel_win.cc(460)] pipe error: 232
[4364:4336:1003/154617:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[4476:608:1003/154621:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[4364:4336:1003/154621:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[2580:3252:1003/154625:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[4364:4336:1003/154626:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[1512:2096:1003/154630:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[4364:4336:1003/154630:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[3224:3008:1003/154634:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3224:4444:1003/154635:ERROR:ipc_channel_win.cc(460)] pipe error: 232
[4364:4336:1003/154635:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[4940:952:1003/154638:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[4364:4336:1003/154639:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[4504:1880:1003/154642:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[4364:4336:1003/154643:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue

RequestContentScriptAPITest.PermissionMatcherAgreementInjection (run #4):
[ RUN      ] RequestContentScriptAPITest.PermissionMatcherAgreementInjection
[3680:3316:1003/154649:WARNING:data_reduction_proxy_settings.cc(331)] SPDY proxy
OFF at startup
[2616:2224:1003/154654:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[1976:4988:1003/154658:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3680:2176:1003/154659:WARNING:embedded_test_server.cc(242)] Request not
handled. Returning 404: /favicon.ico
[3680:4484:1003/154659:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[1952:3576:1003/154703:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3680:4484:1003/154704:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[4836:1344:1003/154708:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[4836:3412:1003/154709:ERROR:ipc_channel_win.cc(460)] pipe error: 232
[3680:4484:1003/154709:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[5088:2760:1003/154713:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3680:4484:1003/154714:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[2952:4052:1003/154719:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[2952:4320:1003/154719:ERROR:ipc_channel_win.cc(460)] pipe error: 232
[3680:4484:1003/154719:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[4208:4748:1003/154724:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[3680:4484:1003/154725:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue
[2272:4456:1003/154728:ERROR:singleton_hwnd.cc(43)] Cannot create windows on
non-UI thread!
[2272:2944:1003/154729:ERROR:ipc_channel_win.cc(460)] pipe error: 232
[3680:4484:1003/154729:WARNING:message_in_transit_queue.cc(18)] Destroying
nonempty message queue

[Yoyo Zhou, 2014-10-03 23:27:04]

On 2014/10/03 22:58:30, Rouslan Solomakhin wrote:
> Hi, this patch may have broken
> RequestContentScriptAPITest.PermissionMatcherAgreementInjection on
> https://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20(dbg)(1)

Seems unlikely considering that this is a refactoring that changes literally
zero functionality.