Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(236)

Side by Side Diff: extensions/shell/common/shell_extensions_client.cc

Issue 622343002: replace OVERRIDE and FINAL with override and final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "extensions/shell/common/shell_extensions_client.h" 5 #include "extensions/shell/common/shell_extensions_client.h"
6 6
7 #include "base/lazy_instance.h" 7 #include "base/lazy_instance.h"
8 #include "base/logging.h" 8 #include "base/logging.h"
9 #include "extensions/common/api/generated_schemas.h" 9 #include "extensions/common/api/generated_schemas.h"
10 #include "extensions/common/common_manifest_handlers.h" 10 #include "extensions/common/common_manifest_handlers.h"
(...skipping 23 matching lines...) Expand all
34 // TODO(jamescook): Refactor ChromePermissionsMessageProvider so we can share 34 // TODO(jamescook): Refactor ChromePermissionsMessageProvider so we can share
35 // code. For now, this implementation does nothing. 35 // code. For now, this implementation does nothing.
36 class ShellPermissionMessageProvider : public PermissionMessageProvider { 36 class ShellPermissionMessageProvider : public PermissionMessageProvider {
37 public: 37 public:
38 ShellPermissionMessageProvider() {} 38 ShellPermissionMessageProvider() {}
39 virtual ~ShellPermissionMessageProvider() {} 39 virtual ~ShellPermissionMessageProvider() {}
40 40
41 // PermissionMessageProvider implementation. 41 // PermissionMessageProvider implementation.
42 virtual PermissionMessages GetPermissionMessages( 42 virtual PermissionMessages GetPermissionMessages(
43 const PermissionSet* permissions, 43 const PermissionSet* permissions,
44 Manifest::Type extension_type) const OVERRIDE { 44 Manifest::Type extension_type) const override {
45 return PermissionMessages(); 45 return PermissionMessages();
46 } 46 }
47 47
48 virtual std::vector<base::string16> GetWarningMessages( 48 virtual std::vector<base::string16> GetWarningMessages(
49 const PermissionSet* permissions, 49 const PermissionSet* permissions,
50 Manifest::Type extension_type) const OVERRIDE { 50 Manifest::Type extension_type) const override {
51 return std::vector<base::string16>(); 51 return std::vector<base::string16>();
52 } 52 }
53 53
54 virtual std::vector<base::string16> GetWarningMessagesDetails( 54 virtual std::vector<base::string16> GetWarningMessagesDetails(
55 const PermissionSet* permissions, 55 const PermissionSet* permissions,
56 Manifest::Type extension_type) const OVERRIDE { 56 Manifest::Type extension_type) const override {
57 return std::vector<base::string16>(); 57 return std::vector<base::string16>();
58 } 58 }
59 59
60 virtual bool IsPrivilegeIncrease( 60 virtual bool IsPrivilegeIncrease(
61 const PermissionSet* old_permissions, 61 const PermissionSet* old_permissions,
62 const PermissionSet* new_permissions, 62 const PermissionSet* new_permissions,
63 Manifest::Type extension_type) const OVERRIDE { 63 Manifest::Type extension_type) const override {
64 // Ensure we implement this before shipping. 64 // Ensure we implement this before shipping.
65 CHECK(false); 65 CHECK(false);
66 return false; 66 return false;
67 } 67 }
68 68
69 private: 69 private:
70 DISALLOW_COPY_AND_ASSIGN(ShellPermissionMessageProvider); 70 DISALLOW_COPY_AND_ASSIGN(ShellPermissionMessageProvider);
71 }; 71 };
72 72
73 base::LazyInstance<ShellPermissionMessageProvider> 73 base::LazyInstance<ShellPermissionMessageProvider>
(...skipping 121 matching lines...) Expand 10 before | Expand all | Expand 10 after
195 return extension_urls::kChromeWebstoreUpdateURL; 195 return extension_urls::kChromeWebstoreUpdateURL;
196 } 196 }
197 197
198 bool ShellExtensionsClient::IsBlacklistUpdateURL(const GURL& url) const { 198 bool ShellExtensionsClient::IsBlacklistUpdateURL(const GURL& url) const {
199 // TODO(rockot): Maybe we want to do something else here. For now we accept 199 // TODO(rockot): Maybe we want to do something else here. For now we accept
200 // any URL as a blacklist URL because we don't really care. 200 // any URL as a blacklist URL because we don't really care.
201 return true; 201 return true;
202 } 202 }
203 203
204 } // namespace extensions 204 } // namespace extensions
OLDNEW
« no previous file with comments | « extensions/shell/common/shell_extensions_client.h ('k') | extensions/shell/renderer/shell_content_renderer_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698