Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Side by Side Diff: extensions/renderer/dom_activity_logger.h

Issue 622343002: replace OVERRIDE and FINAL with override and final in extensions/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « extensions/renderer/dispatcher.h ('k') | extensions/renderer/event_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_ 5 #ifndef EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_
6 #define EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_ 6 #define EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 28 matching lines...) Expand all
39 // corresponding to world_id, and if so, construct a new logger and attach it. 39 // corresponding to world_id, and if so, construct a new logger and attach it.
40 // world_id = 0 indicates the main world. 40 // world_id = 0 indicates the main world.
41 static void AttachToWorld(int world_id, 41 static void AttachToWorld(int world_id,
42 const std::string& extension_id); 42 const std::string& extension_id);
43 43
44 private: 44 private:
45 // blink::WebDOMActivityLogger implementation. 45 // blink::WebDOMActivityLogger implementation.
46 // Marshals the arguments into an ExtensionHostMsg_DOMAction_Params and sends 46 // Marshals the arguments into an ExtensionHostMsg_DOMAction_Params and sends
47 // it over to the browser (via IPC) for appending it to the extension activity 47 // it over to the browser (via IPC) for appending it to the extension activity
48 // log. 48 // log.
49 // These methods don't have the OVERRIDE keyword due to the complexities it 49 // These methods don't have the override keyword due to the complexities it
50 // introduces when changes blink apis. 50 // introduces when changes blink apis.
51 virtual void logGetter(const blink::WebString& api_name, 51 virtual void logGetter(const blink::WebString& api_name,
52 const blink::WebURL& url, 52 const blink::WebURL& url,
53 const blink::WebString& title); 53 const blink::WebString& title);
54 virtual void logSetter(const blink::WebString& api_name, 54 virtual void logSetter(const blink::WebString& api_name,
55 const v8::Handle<v8::Value>& new_value, 55 const v8::Handle<v8::Value>& new_value,
56 const blink::WebURL& url, 56 const blink::WebURL& url,
57 const blink::WebString& title); 57 const blink::WebString& title);
58 virtual void logSetter(const blink::WebString& api_name, 58 virtual void logSetter(const blink::WebString& api_name,
59 const v8::Handle<v8::Value>& new_value, 59 const v8::Handle<v8::Value>& new_value,
(...skipping 21 matching lines...) Expand all
81 // The id of the extension with which this logger is associated. 81 // The id of the extension with which this logger is associated.
82 std::string extension_id_; 82 std::string extension_id_;
83 83
84 DISALLOW_COPY_AND_ASSIGN(DOMActivityLogger); 84 DISALLOW_COPY_AND_ASSIGN(DOMActivityLogger);
85 }; 85 };
86 86
87 } // namespace extensions 87 } // namespace extensions
88 88
89 #endif // EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_ 89 #endif // EXTENSIONS_RENDERER_DOM_ACTIVITY_LOGGER_H_
90 90
OLDNEW
« no previous file with comments | « extensions/renderer/dispatcher.h ('k') | extensions/renderer/event_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698