Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(193)

Issue 622333002: Flip the true/false result of ScriptState::contextIsValid (Closed)

Created:
6 years, 2 months ago by haraken
Modified:
6 years, 2 months ago
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, mkwst+moarreviews_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Project:
blink
Visibility:
Public.

Description

Flip the true/false result of ScriptState::contextIsValid Currently ScriptState::contextIsValid returns true when the context is not valid. This is very confusing. This CL flips the true/false. This CL doesn't fix bug 419624. This is just a preparation for fixing bug 419624 (actually I have no idea at the moment though). BUG=419624 TBR=jochen Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=183271

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -34 lines) Patch
M Source/bindings/core/v8/ScheduledAction.cpp View 3 4 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptController.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/ScriptDebugServer.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/ScriptState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptStreamer.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/ScriptValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8AbstractEventListener.cpp View 3 2 chunks +2 lines, -2 lines 0 comments Download
M Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/bindings/core/v8/V8EventListenerList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8MutationCallback.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/V8WorkerGlobalScopeEventListener.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/core/v8/custom/V8WindowCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/modules/v8/custom/V8CustomSQLStatementErrorCallback.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/callback_interface.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/tests/results/core/V8TestCallbackInterface.cpp View 10 chunks +10 lines, -10 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/PageRuntimeAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPluginContainerImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 22 (9 generated)
haraken
PTAL
6 years, 2 months ago (2014-10-03 10:03:18 UTC) #2
Jens Widell
What about the three calls in Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp?
6 years, 2 months ago (2014-10-03 10:11:39 UTC) #3
haraken
On 2014/10/03 10:11:39, Jens Widell wrote: > What about the three calls in > Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp? ...
6 years, 2 months ago (2014-10-03 10:21:38 UTC) #4
Jens Widell
LGTM The new name is less misleading, certainly. :-)
6 years, 2 months ago (2014-10-03 10:24:13 UTC) #5
haraken
Thanks for the careful review.
6 years, 2 months ago (2014-10-03 11:57:04 UTC) #6
haraken
TBRing jochen@ for web/.
6 years, 2 months ago (2014-10-03 11:57:44 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622333002/20001
6 years, 2 months ago (2014-10-03 11:59:14 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/27581)
6 years, 2 months ago (2014-10-03 13:10:01 UTC) #14
jochen (gone - plz use gerrit)
d'oh lgtm
6 years, 2 months ago (2014-10-06 07:25:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622333002/40001
6 years, 2 months ago (2014-10-06 08:59:51 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/27804) mac_gpu_retina_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu_retina_triggered_tests/builds/55015)
6 years, 2 months ago (2014-10-06 09:24:33 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/622333002/80001
6 years, 2 months ago (2014-10-06 13:04:44 UTC) #21
commit-bot: I haz the power
6 years, 2 months ago (2014-10-06 14:16:08 UTC) #22
Message was sent while issue was closed.
Committed patchset #5 (id:80001) as 183271

Powered by Google App Engine
This is Rietveld 408576698