Source/bindings/core/v8/ScriptValue.cpp - Issue 622333002: Flip the true/false result of ScriptState::contextIsValid

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/bindings/core/v8/ScriptValue.cpp

Issue 622333002: Flip the true/false result of ScriptState::contextIsValid (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « Source/bindings/core/v8/ScriptStreamer.cpp ('k') | Source/bindings/core/v8/V8AbstractEventListener.cpp » ('j') | no next file with comments »

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.	2 * Copyright (C) 2008, 2009, 2011 Google Inc. All rights reserved.

3 *	3 *

4 * Redistribution and use in source and binary forms, with or without	4 * Redistribution and use in source and binary forms, with or without

5 * modification, are permitted provided that the following conditions are	5 * modification, are permitted provided that the following conditions are

6 * met:	6 * met:

7 *	7 *

8 * * Redistributions of source code must retain the above copyright	8 * * Redistributions of source code must retain the above copyright

9 * notice, this list of conditions and the following disclaimer.	9 * notice, this list of conditions and the following disclaimer.

10 * * Redistributions in binary form must reproduce the above	10 * * Redistributions in binary form must reproduce the above

(...skipping 58 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
69 ScriptState::Scope scope(m_scriptState.get());	69 ScriptState::Scope scope(m_scriptState.get());

70 v8::Handle<v8::Value> string = v8Value();	70 v8::Handle<v8::Value> string = v8Value();

71 if (string.IsEmpty() \|\| !string->IsString())	71 if (string.IsEmpty() \|\| !string->IsString())

72 return false;	72 return false;

73 result = toCoreString(v8::Handle<v8::String>::Cast(string));	73 result = toCoreString(v8::Handle<v8::String>::Cast(string));

74 return true;	74 return true;

75 }	75 }

76	76

77 PassRefPtr<JSONValue> ScriptValue::toJSONValue(ScriptState* scriptState) const	77 PassRefPtr<JSONValue> ScriptValue::toJSONValue(ScriptState* scriptState) const

78 {	78 {

79 ASSERT(!scriptState->contextIsValid());	79 ASSERT(scriptState->contextIsValid());

80 ScriptState::Scope scope(scriptState);	80 ScriptState::Scope scope(scriptState);

81 return v8ToJSONValue(scriptState->isolate(), v8Value(), JSONValue::maxDepth) ;	81 return v8ToJSONValue(scriptState->isolate(), v8Value(), JSONValue::maxDepth) ;

82 }	82 }

83	83

84 } // namespace blink	84 } // namespace blink

OLD	NEW