Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp - Issue 622333002: Flip the true/false result of ScriptState::contextIsValid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp

Issue 622333002: Flip the true/false result of ScriptState::contextIsValid (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp

diff --git a/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp b/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp

index 87abb53aef6accf70d1d142a68bd3fa3679d7a18..524f815f6f5b2aad747d162bcd2f1e2dfd3788da 100644

--- a/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp

+++ b/Source/bindings/core/v8/V8CustomElementLifecycleCallbacks.cpp

@@ -158,7 +158,7 @@ void V8CustomElementLifecycleCallbacks::created(Element* element)

element->setCustomElementState(Element::Upgraded);

- if (m_scriptState->contextIsValid())

+ if (!m_scriptState->contextIsValid())

return;

ScriptState::Scope scope(m_scriptState.get());

v8::Isolate* isolate = m_scriptState->isolate();

@@ -208,7 +208,7 @@ void V8CustomElementLifecycleCallbacks::attributeChanged(Element* element, const

if (!executionContext() || executionContext()->activeDOMObjectsAreStopped())

return;

- if (m_scriptState->contextIsValid())

+ if (!m_scriptState->contextIsValid())

return;

ScriptState::Scope scope(m_scriptState.get());

v8::Isolate* isolate = m_scriptState->isolate();

@@ -241,7 +241,7 @@ void V8CustomElementLifecycleCallbacks::call(const ScopedPersistent<v8::Function

if (!executionContext() || executionContext()->activeDOMObjectsAreStopped())

return;

- if (m_scriptState->contextIsValid())

+ if (!m_scriptState->contextIsValid())

return;

ScriptState::Scope scope(m_scriptState.get());

v8::Isolate* isolate = m_scriptState->isolate();