Source/bindings/core/v8/ScriptState.h - Issue 622333002: Flip the true/false result of ScriptState::contextIsValid

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/core/v8/ScriptState.h

Issue 622333002: Flip the true/false result of ScriptState::contextIsValid (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/core/v8/ScriptState.h

diff --git a/Source/bindings/core/v8/ScriptState.h b/Source/bindings/core/v8/ScriptState.h

index bfcbdf126ba44a91878e607aeca8a4ed5a1d04fa..38cfe99d1cbfb6f395ef499f8cbf7a0abfff17f2 100644

--- a/Source/bindings/core/v8/ScriptState.h

+++ b/Source/bindings/core/v8/ScriptState.h

@@ -74,7 +74,7 @@ public:

// This can return an empty handle if the v8::Context is gone.

v8::Handle<v8::Context> context() const { return m_context.newLocal(m_isolate); }

- bool contextIsValid() const { return m_context.isEmpty() || m_globalObjectDetached; }

+ bool contextIsValid() const { return !m_context.isEmpty() && !m_globalObjectDetached; }

void detachGlobalObject();

void clearContext() { return m_context.clear(); }