Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(371)

Issue 621673002: command_buffer: Remove unused shared id code (GenSharedIdsCHROMIUM, ...) (Closed)

Created:
6 years, 2 months ago by Kimmo Kinnunen
Modified:
6 years, 2 months ago
Reviewers:
vmiura, piman
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

command_buffer: Remove unused shared id code (GenSharedIdsCHROMIUM, ...) Remove unused shared id code from gpu command buffer. The functions removed are glGenSharedIdsCHROMIUM, glDeleteSharedIdsCHROMIUM, glRegisterSharedIdsCHROMIUM. The functions are not specified by the pseudo-extensions and it appears as if they have never been called. Also PPAPI does not expose these. This simplifies working with id generation logic. Removes the extra, unused id allocation for various id namespaces from the service side. Also fixes gpu process null pointer deref when the *SharedId commands would have an invalid namespace id. Committed: https://crrev.com/06d32878eeabdf9a12c76b8ee89bd5ac5b81d648 Cr-Commit-Position: refs/heads/master@{#298012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -897 lines) Patch
M gpu/GLES2/gl2chromium_autogen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/build_gles2_cmd_buffer.py View 4 chunks +2 lines, -28 lines 0 comments Download
M gpu/command_buffer/client/gles2_c_lib_autogen.h View 2 chunks +0 lines, -28 lines 0 comments Download
M gpu/command_buffer/client/gles2_cmd_helper_autogen.h View 1 chunk +0 lines, -34 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation.cc View 2 chunks +1 line, -82 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_autogen.h View 1 chunk +0 lines, -13 lines 0 comments Download
M gpu/command_buffer/client/gles2_implementation_impl_autogen.h View 1 chunk +1 line, -1 line 0 comments Download
M gpu/command_buffer/client/gles2_implementation_unittest_autogen.h View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_autogen.h View 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_autogen.h View 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/client/gles2_interface_stub_impl_autogen.h View 1 chunk +0 lines, -13 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_autogen.h View 1 chunk +0 lines, -10 lines 0 comments Download
M gpu/command_buffer/client/gles2_trace_implementation_impl_autogen.h View 1 chunk +0 lines, -22 lines 0 comments Download
M gpu/command_buffer/cmd_buffer_functions.txt View 1 chunk +0 lines, -3 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_autogen.h View 1 chunk +0 lines, -165 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_format_test_autogen.h View 1 chunk +0 lines, -55 lines 0 comments Download
M gpu/command_buffer/common/gles2_cmd_ids_autogen.h View 1 chunk +36 lines, -39 lines 0 comments Download
M gpu/command_buffer/common/id_allocator.h View 2 chunks +9 lines, -43 lines 0 comments Download
M gpu/command_buffer/common/id_allocator.cc View 2 chunks +0 lines, -33 lines 0 comments Download
M gpu/command_buffer/service/context_group.h View 3 chunks +0 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/context_group.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 9 chunks +0 lines, -140 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 2 chunks +0 lines, -118 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_2_autogen.h View 2 chunks +4 lines, -6 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_3_autogen.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_attribs.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_base.h View 1 chunk +0 lines, -4 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_context_state.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_drawing.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_framebuffers.cc View 1 chunk +0 lines, -1 line 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest_programs.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Kimmo Kinnunen
6 years, 2 months ago (2014-10-01 05:50:27 UTC) #2
piman
LGTM, that's a nice cleanup!
6 years, 2 months ago (2014-10-03 03:40:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/621673002/1
6 years, 2 months ago (2014-10-03 06:22:07 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8d1ccef7c8020140b7d6f6827d906a76a8c8f626
6 years, 2 months ago (2014-10-03 08:30:47 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-03 08:31:28 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/06d32878eeabdf9a12c76b8ee89bd5ac5b81d648
Cr-Commit-Position: refs/heads/master@{#298012}

Powered by Google App Engine
This is Rietveld 408576698