Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 619623003: Mojo: Don't do any work in ProxyMessagePipeEndpoint's destructor. (Closed)

Created:
6 years, 2 months ago by viettrungluu
Modified:
6 years, 2 months ago
Reviewers:
brettw
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, mkwst+moarreviews-ipc_chromium.org, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Mojo: Don't do any work in ProxyMessagePipeEndpoint's destructor. In particular, detach from the ChannelEndpoint earlier. (The ChannelEndpoint has a pointer to the MessagePipe that owns the ProxyMessagePipeEndpoint. It should always be valid. Detaching in the ProxyMessagePipeEndpoint's destructor means that that pointer is momentarily not really valid -- "not really" in that the memory still exists, but it's in the middle of the MessagePipe's destruction.) R=brettw@chromium.org Committed: https://crrev.com/15235c63c9a50d40d31f766bd968feaa8c298876 Cr-Commit-Position: refs/heads/master@{#297673}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -5 lines) Patch
M mojo/system/message_pipe_endpoint.h View 2 chunks +1 line, -1 line 0 comments Download
M mojo/system/message_pipe_endpoint.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.h View 1 chunk +3 lines, -0 lines 0 comments Download
M mojo/system/proxy_message_pipe_endpoint.cc View 3 chunks +13 lines, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
6 years, 2 months ago (2014-09-30 22:51:46 UTC) #1
brettw
lgtm
6 years, 2 months ago (2014-10-01 17:40:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/619623003/1
6 years, 2 months ago (2014-10-01 17:46:03 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as ebfb4ff0370c7dcd7018d7d84ed8641f5c2ca58f
6 years, 2 months ago (2014-10-01 17:51:08 UTC) #5
commit-bot: I haz the power
6 years, 2 months ago (2014-10-01 17:51:39 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/15235c63c9a50d40d31f766bd968feaa8c298876
Cr-Commit-Position: refs/heads/master@{#297673}

Powered by Google App Engine
This is Rietveld 408576698