Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Side by Side Diff: mojo/system/message_pipe_endpoint.h

Issue 619623003: Mojo: Don't do any work in ProxyMessagePipeEndpoint's destructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | mojo/system/message_pipe_endpoint.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_SYSTEM_MESSAGE_PIPE_ENDPOINT_H_ 5 #ifndef MOJO_SYSTEM_MESSAGE_PIPE_ENDPOINT_H_
6 #define MOJO_SYSTEM_MESSAGE_PIPE_ENDPOINT_H_ 6 #define MOJO_SYSTEM_MESSAGE_PIPE_ENDPOINT_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <vector> 10 #include <vector>
(...skipping 30 matching lines...) Expand all
41 virtual Type GetType() const = 0; 41 virtual Type GetType() const = 0;
42 42
43 // All implementations must implement these. 43 // All implementations must implement these.
44 // Returns false if the endpoint should be closed and destroyed, else true. 44 // Returns false if the endpoint should be closed and destroyed, else true.
45 virtual bool OnPeerClose() = 0; 45 virtual bool OnPeerClose() = 0;
46 // Implements |MessagePipe::EnqueueMessage()|. The major differences are that: 46 // Implements |MessagePipe::EnqueueMessage()|. The major differences are that:
47 // a) Dispatchers have been vetted and cloned/attached to the message. 47 // a) Dispatchers have been vetted and cloned/attached to the message.
48 // b) At this point, we cannot report failure (if, e.g., a channel is torn 48 // b) At this point, we cannot report failure (if, e.g., a channel is torn
49 // down at this point, we should silently swallow the message). 49 // down at this point, we should silently swallow the message).
50 virtual void EnqueueMessage(scoped_ptr<MessageInTransit> message) = 0; 50 virtual void EnqueueMessage(scoped_ptr<MessageInTransit> message) = 0;
51 virtual void Close() = 0;
51 52
52 // Implementations must override these if they represent a local endpoint, 53 // Implementations must override these if they represent a local endpoint,
53 // i.e., one for which there's a |MessagePipeDispatcher| (and thus a handle). 54 // i.e., one for which there's a |MessagePipeDispatcher| (and thus a handle).
54 // An implementation for a proxy endpoint (for which there's no dispatcher) 55 // An implementation for a proxy endpoint (for which there's no dispatcher)
55 // needs not override these methods, since they should never be called. 56 // needs not override these methods, since they should never be called.
56 // 57 //
57 // These methods implement the methods of the same name in |MessagePipe|, 58 // These methods implement the methods of the same name in |MessagePipe|,
58 // though |MessagePipe|'s implementation may have to do a little more if the 59 // though |MessagePipe|'s implementation may have to do a little more if the
59 // operation involves both endpoints. 60 // operation involves both endpoints.
60 virtual void Close();
61 virtual void CancelAllWaiters(); 61 virtual void CancelAllWaiters();
62 virtual MojoResult ReadMessage(UserPointer<void> bytes, 62 virtual MojoResult ReadMessage(UserPointer<void> bytes,
63 UserPointer<uint32_t> num_bytes, 63 UserPointer<uint32_t> num_bytes,
64 DispatcherVector* dispatchers, 64 DispatcherVector* dispatchers,
65 uint32_t* num_dispatchers, 65 uint32_t* num_dispatchers,
66 MojoReadMessageFlags flags); 66 MojoReadMessageFlags flags);
67 virtual HandleSignalsState GetHandleSignalsState() const; 67 virtual HandleSignalsState GetHandleSignalsState() const;
68 virtual MojoResult AddWaiter(Waiter* waiter, 68 virtual MojoResult AddWaiter(Waiter* waiter,
69 MojoHandleSignals signals, 69 MojoHandleSignals signals,
70 uint32_t context, 70 uint32_t context,
71 HandleSignalsState* signals_state); 71 HandleSignalsState* signals_state);
72 virtual void RemoveWaiter(Waiter* waiter, HandleSignalsState* signals_state); 72 virtual void RemoveWaiter(Waiter* waiter, HandleSignalsState* signals_state);
73 73
74 // Implementations must override these if they represent a proxy endpoint. An 74 // Implementations must override these if they represent a proxy endpoint. An
75 // implementation for a local endpoint needs not override these methods, since 75 // implementation for a local endpoint needs not override these methods, since
76 // they should never be called. 76 // they should never be called.
77 virtual void Attach(ChannelEndpoint* channel_endpoint); 77 virtual void Attach(ChannelEndpoint* channel_endpoint);
78 78
79 protected: 79 protected:
80 MessagePipeEndpoint() {} 80 MessagePipeEndpoint() {}
81 81
82 private: 82 private:
83 DISALLOW_COPY_AND_ASSIGN(MessagePipeEndpoint); 83 DISALLOW_COPY_AND_ASSIGN(MessagePipeEndpoint);
84 }; 84 };
85 85
86 } // namespace system 86 } // namespace system
87 } // namespace mojo 87 } // namespace mojo
88 88
89 #endif // MOJO_SYSTEM_MESSAGE_PIPE_ENDPOINT_H_ 89 #endif // MOJO_SYSTEM_MESSAGE_PIPE_ENDPOINT_H_
OLDNEW
« no previous file with comments | « no previous file | mojo/system/message_pipe_endpoint.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698