Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: mojo/system/message_pipe_endpoint.h

Issue 619623003: Mojo: Don't do any work in ProxyMessagePipeEndpoint's destructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | mojo/system/message_pipe_endpoint.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/message_pipe_endpoint.h
diff --git a/mojo/system/message_pipe_endpoint.h b/mojo/system/message_pipe_endpoint.h
index 781a61676e6ed062c3865000f565d521dd369562..c8a01fa244dd1c9de36213a554571839320ae192 100644
--- a/mojo/system/message_pipe_endpoint.h
+++ b/mojo/system/message_pipe_endpoint.h
@@ -48,6 +48,7 @@ class MOJO_SYSTEM_IMPL_EXPORT MessagePipeEndpoint {
// b) At this point, we cannot report failure (if, e.g., a channel is torn
// down at this point, we should silently swallow the message).
virtual void EnqueueMessage(scoped_ptr<MessageInTransit> message) = 0;
+ virtual void Close() = 0;
// Implementations must override these if they represent a local endpoint,
// i.e., one for which there's a |MessagePipeDispatcher| (and thus a handle).
@@ -57,7 +58,6 @@ class MOJO_SYSTEM_IMPL_EXPORT MessagePipeEndpoint {
// These methods implement the methods of the same name in |MessagePipe|,
// though |MessagePipe|'s implementation may have to do a little more if the
// operation involves both endpoints.
- virtual void Close();
virtual void CancelAllWaiters();
virtual MojoResult ReadMessage(UserPointer<void> bytes,
UserPointer<uint32_t> num_bytes,
« no previous file with comments | « no previous file | mojo/system/message_pipe_endpoint.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698