Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Side by Side Diff: mojo/system/proxy_message_pipe_endpoint.h

Issue 619623003: Mojo: Don't do any work in ProxyMessagePipeEndpoint's destructor. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « mojo/system/message_pipe_endpoint.cc ('k') | mojo/system/proxy_message_pipe_endpoint.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef MOJO_SYSTEM_PROXY_MESSAGE_PIPE_ENDPOINT_H_ 5 #ifndef MOJO_SYSTEM_PROXY_MESSAGE_PIPE_ENDPOINT_H_
6 #define MOJO_SYSTEM_PROXY_MESSAGE_PIPE_ENDPOINT_H_ 6 #define MOJO_SYSTEM_PROXY_MESSAGE_PIPE_ENDPOINT_H_
7 7
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "base/memory/ref_counted.h" 9 #include "base/memory/ref_counted.h"
10 #include "mojo/system/message_in_transit.h" 10 #include "mojo/system/message_in_transit.h"
(...skipping 19 matching lines...) Expand all
30 class MOJO_SYSTEM_IMPL_EXPORT ProxyMessagePipeEndpoint 30 class MOJO_SYSTEM_IMPL_EXPORT ProxyMessagePipeEndpoint
31 : public MessagePipeEndpoint { 31 : public MessagePipeEndpoint {
32 public: 32 public:
33 explicit ProxyMessagePipeEndpoint(ChannelEndpoint* channel_endpoint); 33 explicit ProxyMessagePipeEndpoint(ChannelEndpoint* channel_endpoint);
34 virtual ~ProxyMessagePipeEndpoint(); 34 virtual ~ProxyMessagePipeEndpoint();
35 35
36 // |MessagePipeEndpoint| implementation: 36 // |MessagePipeEndpoint| implementation:
37 virtual Type GetType() const override; 37 virtual Type GetType() const override;
38 virtual bool OnPeerClose() override; 38 virtual bool OnPeerClose() override;
39 virtual void EnqueueMessage(scoped_ptr<MessageInTransit> message) override; 39 virtual void EnqueueMessage(scoped_ptr<MessageInTransit> message) override;
40 virtual void Close() override;
40 41
41 private: 42 private:
43 void DetachIfNecessary();
44
42 scoped_refptr<ChannelEndpoint> channel_endpoint_; 45 scoped_refptr<ChannelEndpoint> channel_endpoint_;
43 46
44 DISALLOW_COPY_AND_ASSIGN(ProxyMessagePipeEndpoint); 47 DISALLOW_COPY_AND_ASSIGN(ProxyMessagePipeEndpoint);
45 }; 48 };
46 49
47 } // namespace system 50 } // namespace system
48 } // namespace mojo 51 } // namespace mojo
49 52
50 #endif // MOJO_SYSTEM_PROXY_MESSAGE_PIPE_ENDPOINT_H_ 53 #endif // MOJO_SYSTEM_PROXY_MESSAGE_PIPE_ENDPOINT_H_
OLDNEW
« no previous file with comments | « mojo/system/message_pipe_endpoint.cc ('k') | mojo/system/proxy_message_pipe_endpoint.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698