Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(365)

Issue 618733002: Revert of Make "priv" classes for GrTexure and GrSurface. (Closed)

Created:
6 years, 2 months ago by robertphillips
Modified:
6 years, 2 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Revert of Make "priv" classes for GrTexure and GrSurface. (patchset #9 id:260001 of https://codereview.chromium.org/596053002/) Reason for revert: Breaking the Chrome builds with: lib/libcc.so: error: undefined reference to 'GrAutoScratchTexture::detach()' (http://108.170.220.120:10117/builders/Canary-Chrome-Ubuntu13.10-Ninja-x86_64-DRT/builds/2990/steps/Retry_BuildContentShell_1/logs/stdio) Original issue's description: > Make "priv" classes for GrTexure and GrSurface. TBR=egdaniel@google.com,joshualitt@google.com,bsalomon@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/b06e5a2f558133b865cb0c3cc0b36e9bd2e594e2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+191 lines, -304 lines) Patch
M bench/GrResourceCacheBench.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M gyp/gpu.gypi View 2 chunks +0 lines, -2 lines 0 comments Download
M include/gpu/GrContext.h View 1 chunk +18 lines, -1 line 0 comments Download
M include/gpu/GrSurface.h View 5 chunks +27 lines, -15 lines 0 comments Download
M include/gpu/GrTexture.h View 5 chunks +74 lines, -17 lines 0 comments Download
M src/gpu/GrBitmapTextContext.cpp View 2 chunks +8 lines, -9 lines 0 comments Download
M src/gpu/GrContext.cpp View 10 chunks +10 lines, -31 lines 0 comments Download
M src/gpu/GrDistanceFieldTextContext.cpp View 2 chunks +6 lines, -8 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrSurface.cpp View 3 chunks +2 lines, -16 lines 0 comments Download
D src/gpu/GrSurfacePriv.h View 1 chunk +0 lines, -63 lines 0 comments Download
M src/gpu/GrTextStrike.cpp View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/GrTexture.cpp View 8 chunks +18 lines, -22 lines 0 comments Download
D src/gpu/GrTexturePriv.h View 1 chunk +0 lines, -82 lines 0 comments Download
M src/gpu/SkGpuDevice.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/gpu/SkGpuDevice.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M src/gpu/gl/GrGLTexture.h View 2 chunks +2 lines, -2 lines 0 comments Download
M src/gpu/gl/GrGpuGL.cpp View 6 chunks +6 lines, -8 lines 0 comments Download
M tests/GrSurfaceTest.cpp View 3 chunks +13 lines, -16 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
robertphillips
Created Revert of Make "priv" classes for GrTexure and GrSurface.
6 years, 2 months ago (2014-09-30 13:57:11 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/618733002/1
6 years, 2 months ago (2014-09-30 13:58:05 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as b06e5a2f558133b865cb0c3cc0b36e9bd2e594e2
6 years, 2 months ago (2014-09-30 13:58:24 UTC) #3
bsalomon
On 2014/09/30 13:58:24, I haz the power (commit-bot) wrote: > Committed patchset #1 (id:1) as ...
6 years, 2 months ago (2014-09-30 14:31:39 UTC) #4
robertphillips
Here is one of the effected DEPS rolls: https://codereview.chromium.org/619643002/
6 years, 2 months ago (2014-09-30 14:56:46 UTC) #5
bsalomon
On 2014/09/30 14:56:46, robertphillips wrote: > Here is one of the effected DEPS rolls: > ...
6 years, 2 months ago (2014-09-30 15:00:25 UTC) #6
robertphillips
Note that (GrResourceCache2 manages scratch texture - https://codereview.chromium.org/608883003) magically fixed the compilation issue but seemed ...
6 years, 2 months ago (2014-09-30 15:02:16 UTC) #7
bsalomon
6 years, 2 months ago (2014-09-30 15:04:18 UTC) #8
Message was sent while issue was closed.
On 2014/09/30 15:02:16, robertphillips wrote:
> Note that (GrResourceCache2 manages scratch texture -
> https://codereview.chromium.org/608883003) magically fixed the compilation
issue
> but seemed to have some other mystery issues (on Ubuntu and Android)

Yup, that change moved the detach defn back to the header.

Powered by Google App Engine
This is Rietveld 408576698