Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Unified Diff: include/gpu/GrSurface.h

Issue 618733002: Revert of Make "priv" classes for GrTexure and GrSurface. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « include/gpu/GrContext.h ('k') | include/gpu/GrTexture.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: include/gpu/GrSurface.h
diff --git a/include/gpu/GrSurface.h b/include/gpu/GrSurface.h
index 23311a2f523e28448a6bf8f17ac7d3e2589a7ecd..24eb39a81b5aef7c4c195906f0bb94a043d5359c 100644
--- a/include/gpu/GrSurface.h
+++ b/include/gpu/GrSurface.h
@@ -11,12 +11,11 @@
#include "GrTypes.h"
#include "GrGpuResource.h"
-#include "SkImageInfo.h"
#include "SkRect.h"
+class GrTexture;
class GrRenderTarget;
-class GrSurfacePriv;
-class GrTexture;
+struct SkImageInfo;
class GrSurface : public GrGpuResource {
public:
@@ -60,6 +59,8 @@
*/
const GrTextureDesc& desc() const { return fDesc; }
+ SkImageInfo info() const;
+
/**
* @return the texture associated with the surface, may be NULL.
*/
@@ -71,6 +72,22 @@
*/
virtual GrRenderTarget* asRenderTarget() = 0;
virtual const GrRenderTarget* asRenderTarget() const = 0;
+
+ /**
+ * Checks whether this GrSurface refers to the same GPU object as other. This
+ * catches the case where a GrTexture and GrRenderTarget refer to the same
+ * GPU memory.
+ */
+ bool isSameAs(const GrSurface* other) const {
+ const GrRenderTarget* thisRT = this->asRenderTarget();
+ if (thisRT) {
+ return thisRT == other->asRenderTarget();
+ } else {
+ const GrTexture* thisTex = this->asTexture();
+ SkASSERT(thisTex); // We must be one or the other
+ return thisTex == other->asTexture();
+ }
+ }
/**
* Reads a rectangle of pixels from the surface.
@@ -112,22 +129,17 @@
size_t rowBytes = 0,
uint32_t pixelOpsFlags = 0) = 0;
- /** Access methods that are only to be used within Skia code. */
- inline GrSurfacePriv surfacePriv();
- inline const GrSurfacePriv surfacePriv() const;
+ /**
+ * Write the contents of the surface to a PNG. Returns true if successful.
+ * @param filename Full path to desired file
+ */
+ bool savePixels(const char* filename);
-protected:
- // Methods made available via GrSurfacePriv
- SkImageInfo info() const;
- bool savePixels(const char* filename);
bool hasPendingRead() const;
bool hasPendingWrite() const;
bool hasPendingIO() const;
- bool isSameAs(const GrSurface* other) const;
- // Provides access to methods that should be public within Skia code.
- friend class GrSurfacePriv;
-
+protected:
GrSurface(GrGpu* gpu, bool isWrapped, const GrTextureDesc& desc)
: INHERITED(gpu, isWrapped)
, fDesc(desc) {
@@ -139,4 +151,4 @@
typedef GrGpuResource INHERITED;
};
-#endif
+#endif // GrSurface_DEFINED
« no previous file with comments | « include/gpu/GrContext.h ('k') | include/gpu/GrTexture.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698