Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Issue 61753010: Move CSSAnimationData and CSSAnimationDataList to platform/ (Closed)

Created:
7 years, 1 month ago by pilgrim_google
Modified:
6 years, 11 months ago
CC:
blink-reviews, shans, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, pdr, loislo+blink_chromium.org, aandrey+blink_chromium.org, dino_apple.com, krit, caseq+blink_chromium.org, Steve Block, alancutter (OOO until 2018), pfeldman+blink_chromium.org, yurys+blink_chromium.org, dstockwell, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, bemjb+rendering_chromium.org, Timothy Loh, rjwright, zoltan1, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, darktears, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, Mike Lawther (Google), f(malita), Eric Willigers, darin (slow to review)
Visibility:
Public.

Description

Move CSSAnimationData and CSSAnimationDataList to platform/ BUG=297477

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1030 lines) Patch
M Source/build/scripts/templates/StyleBuilderFunctions.cpp.tmpl View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/AnimatableVisibility.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/animation/css/CSSAnimations.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/animation/css/CSSAnimations.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/core.gypi View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSPrimitiveValueMappings.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSProperty.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSSelector.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/CSSToStyleMap.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/PseudoStyleRequest.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/ElementResolveContext.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleAdjuster.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/resolver/StyleBuilderCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/VisitedLinkState.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/animation/AnimationBase.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/animation/AnimationTranslationUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/animation/AnimationTranslationUtilTest.cpp View 1 chunk +1 line, -1 line 0 comments Download
D Source/core/platform/animation/CSSAnimationData.h View 1 chunk +0 lines, -192 lines 0 comments Download
D Source/core/platform/animation/CSSAnimationData.cpp View 1 chunk +0 lines, -128 lines 0 comments Download
D Source/core/platform/animation/CSSAnimationDataList.h View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/core/platform/animation/CSSAnimationDataList.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
M Source/core/rendering/PointerEventsHitRules.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderMarquee.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderQuote.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderScrollbar.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/animation/WebAnimationProvider.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/BorderValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/CounterContent.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/FillLayer.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/LineClampValue.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 2 chunks +2 lines, -2 lines 0 comments Download
D Source/core/rendering/style/RenderStyleConstants.h View 1 chunk +0 lines, -530 lines 0 comments Download
M Source/core/rendering/style/SVGRenderStyle.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleBackgroundData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleBoxData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleBoxData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleGridData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleMarqueeData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleMultiColData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleRareInheritedData.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/style/StyleVisualData.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/SVGResourcesCache.h View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/RenderStyleConstants.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + Source/platform/animation/CSSAnimationData.h View 1 chunk +4 lines, -3 lines 0 comments Download
A + Source/platform/animation/CSSAnimationData.cpp View 1 chunk +1 line, -1 line 0 comments Download
A + Source/platform/animation/CSSAnimationDataList.h View 1 chunk +3 lines, -2 lines 0 comments Download
A + Source/platform/animation/CSSAnimationDataList.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/blink_platform.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
pilgrim_google
Blocked by https://codereview.chromium.org/65303006/ which is still in progress.
7 years, 1 month ago (2013-11-13 15:54:59 UTC) #1
pilgrim_google
7 years, 1 month ago (2013-11-13 15:55:12 UTC) #2
Stephen Chennney
Surely files prefixed with CSS should be in core/css rather than platform?
7 years, 1 month ago (2013-11-13 16:47:11 UTC) #3
pilgrim_google
On 2013/11/13 16:47:11, Stephen Chenney wrote: > Surely files prefixed with CSS should be in ...
7 years, 1 month ago (2013-11-13 16:53:43 UTC) #4
Stephen Chennney
On 2013/11/13 16:53:43, pilgrim_google wrote: > On 2013/11/13 16:47:11, Stephen Chenney wrote: > > Surely ...
7 years, 1 month ago (2013-11-13 17:10:01 UTC) #5
rwlbuis
6 years, 11 months ago (2014-01-09 17:34:08 UTC) #6
On 2013/11/13 17:10:01, Stephen Chenney wrote:
> On 2013/11/13 16:53:43, pilgrim_google wrote:
> > On 2013/11/13 16:47:11, Stephen Chenney wrote:
> > > Surely files prefixed with CSS should be in core/css rather than platform?
> > 
> > See previous discussion in https://chromiumcodereview.appspot.com/14391005
and
> > https://codereview.chromium.org/14409013/
> > 
> > And don't call me "Shirley."
> 
> I would like to move the CSS/Style related things to core/animation, which
also
> means you don't have to move the very very CSS specific file
> RenderStyleConstants.

Can this be closed now https://codereview.chromium.org/112463008 landed.

Powered by Google App Engine
This is Rietveld 408576698