Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 14409013: Rename CSSAnimationData* -> StyleAnimationData* (Closed)

Created:
7 years, 7 months ago by shans
Modified:
7 years, 7 months ago
Reviewers:
eseidel, dglazkov1
CC:
blink-reviews, jamesr, danakj, dstockwell, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, Stephen Chennney, Steve Block, jeez
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Rename CSSAnimationData* -> StyleAnimationData* (based on comments after submission on https://chromiumcodereview.appspot.com/14391005/) BUG=234784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+239 lines, -703 lines) Patch
M Source/WebKit/chromium/tests/AnimationTranslationUtilTest.cpp View 13 chunks +16 lines, -16 lines 0 comments Download
M Source/core/core.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/css/CSSComputedStyleDeclaration.cpp View 12 chunks +22 lines, -22 lines 0 comments Download
M Source/core/css/CSSToStyleMap.h View 2 chunks +10 lines, -10 lines 0 comments Download
M Source/core/css/CSSToStyleMap.cpp View 10 chunks +27 lines, -27 lines 0 comments Download
M Source/core/css/StyleBuilder.cpp View 4 chunks +35 lines, -35 lines 0 comments Download
M Source/core/page/animation/AnimationBase.h View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/page/animation/AnimationBase.cpp View 4 chunks +7 lines, -7 lines 0 comments Download
M Source/core/page/animation/CompositeAnimation.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
M Source/core/page/animation/ImplicitAnimation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/animation/ImplicitAnimation.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/animation/KeyframeAnimation.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/animation/KeyframeAnimation.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
D Source/core/platform/animation/CSSAnimationData.h View 1 chunk +0 lines, -191 lines 0 comments Download
D Source/core/platform/animation/CSSAnimationData.cpp View 1 chunk +0 lines, -143 lines 0 comments Download
D Source/core/platform/animation/CSSAnimationDataList.h View 1 chunk +0 lines, -66 lines 0 comments Download
D Source/core/platform/animation/CSSAnimationDataList.cpp View 1 chunk +0 lines, -64 lines 0 comments Download
A + Source/core/platform/animation/StyleAnimationData.h View 5 chunks +15 lines, -15 lines 0 comments Download
A + Source/core/platform/animation/StyleAnimationData.cpp View 5 chunks +8 lines, -8 lines 0 comments Download
A + Source/core/platform/animation/StyleAnimationDataList.h View 2 chunks +14 lines, -14 lines 0 comments Download
A + Source/core/platform/animation/StyleAnimationDataList.cpp View 3 chunks +5 lines, -5 lines 0 comments Download
M Source/core/platform/graphics/GraphicsLayer.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/GraphicsLayerAnimation.h View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/platform/graphics/GraphicsLayerAnimation.cpp View 5 chunks +12 lines, -12 lines 0 comments Download
M Source/core/platform/graphics/chromium/AnimationTranslationUtil.h View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/platform/graphics/chromium/AnimationTranslationUtil.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/platform/graphics/chromium/GraphicsLayerChromium.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/platform/graphics/chromium/GraphicsLayerChromium.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBoxModelObject.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderBoxModelObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerBacking.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerBacking.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.h View 3 chunks +8 lines, -8 lines 0 comments Download
M Source/core/rendering/style/RenderStyle.cpp View 3 chunks +9 lines, -9 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.h View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/rendering/style/StyleRareNonInheritedData.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
shans
7 years, 7 months ago (2013-04-29 21:06:07 UTC) #1
eseidel
I worry I may be leading you astray w/o sufficient context. Why is this in ...
7 years, 7 months ago (2013-04-29 21:16:05 UTC) #2
eseidel
But yes, platform/ doesn't know anything about CSS. But then again it doesn't know anything ...
7 years, 7 months ago (2013-04-29 21:17:00 UTC) #3
shans
On 2013/04/29 21:17:00, Eric Seidel (Google) wrote: > But yes, platform/ doesn't know anything about ...
7 years, 7 months ago (2013-04-29 21:28:57 UTC) #4
shans
7 years, 7 months ago (2013-04-29 21:39:49 UTC) #5
Message was sent while issue was closed.
On 2013/04/29 21:28:57, shans wrote:
> On 2013/04/29 21:17:00, Eric Seidel (Google) wrote:
> > But yes, platform/ doesn't know anything about CSS.  But then again it
doesn't
> > know anything about Style either.  So we're left with me having insufficient
> > context to be helpful in suggesting a better name.
> 
> Perhaps we should just leave it then, or rename it to plain old
'AnimationData'.
> 
> We are in the process of building new animations infrastructure, and intend to
> remove platform/animation when appropriate (hopefully within a few months), so
> I'm reluctant to move things around too much right now. the 'Animation' class
> rename was needed so we could call the new thing 'Animation'.

I've closed this for now. If anyone has strong opinions I'm happy to reopen and
switch to a new name :)

Powered by Google App Engine
This is Rietveld 408576698