Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 617073010: [Findit] Add timestamp of CL commit and fix two bugs. (Closed)

Created:
6 years, 2 months ago by stgao
Modified:
6 years, 2 months ago
Reviewers:
Martin Barbella, aarya
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[Findit] Add timestamp of CL commit and fix two bugs. Two bug fixed: 1. NormalizePath for components. 2. Add expected line separators in reasons. NOTRY=true Committed: https://crrev.com/8d9a76e0a94dd5df7ab579e9f648bef538e11ddb Cr-Commit-Position: refs/heads/master@{#297881}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -22 lines) Patch
M tools/findit/blame.py View 4 chunks +6 lines, -4 lines 0 comments Download
M tools/findit/crash_utils.py View 4 chunks +7 lines, -11 lines 0 comments Download
M tools/findit/findit_for_crash.py View 2 chunks +6 lines, -5 lines 0 comments Download
M tools/findit/git_repository_parser.py View 3 chunks +5 lines, -1 line 0 comments Download
M tools/findit/match_set.py View 2 chunks +2 lines, -0 lines 0 comments Download
M tools/findit/result.py View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
stgao
6 years, 2 months ago (2014-10-02 19:05:51 UTC) #2
aarya
lgtm
6 years, 2 months ago (2014-10-02 19:22:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/617073010/1
6 years, 2 months ago (2014-10-02 19:29:43 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as e09e8ff59ff6ed9af74df32e1c17ed9895220422
6 years, 2 months ago (2014-10-02 19:30:56 UTC) #6
commit-bot: I haz the power
6 years, 2 months ago (2014-10-02 19:33:00 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8d9a76e0a94dd5df7ab579e9f648bef538e11ddb
Cr-Commit-Position: refs/heads/master@{#297881}

Powered by Google App Engine
This is Rietveld 408576698