Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Unified Diff: tools/findit/git_repository_parser.py

Issue 617073010: [Findit] Add timestamp of CL commit and fix two bugs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/findit/findit_for_crash.py ('k') | tools/findit/match_set.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/findit/git_repository_parser.py
diff --git a/tools/findit/git_repository_parser.py b/tools/findit/git_repository_parser.py
index d875c261f313adae84bab6855c3adc12bc783401..7d2d09aeb34a541936ee843d9872c62ca09f5dc9 100644
--- a/tools/findit/git_repository_parser.py
+++ b/tools/findit/git_repository_parser.py
@@ -93,6 +93,8 @@ class GitParser(ParserInterface):
author = trs[1].getElementsByTagName(
'td')[0].firstChild.nodeValue.split('<')[0]
revision['author'] = author
+ revision['time'] = trs[1].getElementsByTagName(
+ 'td')[0].firstChild.nodeValue
# Retrive and set message.
revision['message'] = pre.firstChild.nodeValue
@@ -183,6 +185,7 @@ class GitParser(ParserInterface):
# Set author, message and URL of this CL.
revision['author'] = json_revision['author']['name']
+ revision['time'] = json_revision['author']['time']
revision['message'] = json_revision['message']
revision['url'] = url
@@ -283,7 +286,8 @@ class GitParser(ParserInterface):
(revision_info, _) = self.ParseChangelog(component, revision, revision)
message = revision_info[revision]['message']
- return (content, revision, author, revision_url, message)
+ time = revision_info[revision]['time']
+ return (content, revision, author, revision_url, message, time)
# Return none if the region does not exist.
return None
« no previous file with comments | « tools/findit/findit_for_crash.py ('k') | tools/findit/match_set.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698