Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: tools/findit/crash_utils.py

Issue 617073010: [Findit] Add timestamp of CL commit and fix two bugs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/findit/blame.py ('k') | tools/findit/findit_for_crash.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/findit/crash_utils.py
diff --git a/tools/findit/crash_utils.py b/tools/findit/crash_utils.py
index cdeadd4705d7cb03eb77515b3020fd12373700e1..7e8011334e245959babd2f324f8f35912da685d8 100644
--- a/tools/findit/crash_utils.py
+++ b/tools/findit/crash_utils.py
@@ -224,17 +224,11 @@ def NormalizePath(path, parsed_deps):
# 'Source' but chromium uses 'src/', and blink component path is
# 'src/third_party/WebKit/Source', so add 'Source/' in front of the
# normalized path.
- if not (lower_normalized_path.startswith('src/') or
- lower_normalized_path.startswith('source/')):
-
- if (lower_component_path.endswith('src/') or
- lower_component_path.endswith('source/')):
+ if (lower_component_path == 'src/third_party/webkit/source' and
+ not lower_normalized_path.startswith('source/')):
normalized_path = (current_component_path.split('/')[-2] + '/' +
normalized_path)
- else:
- normalized_path = 'src/' + normalized_path
-
component_name = parsed_deps[component_path]['name']
return (component_path, component_name, normalized_path)
@@ -528,15 +522,16 @@ def MatchListToResultList(matches):
revision_url = match.revision_url
component_name = match.component_name
author = match.author
- reason = match.reason
+ reason = match.reason.strip()
review_url = match.review_url
reviewers = match.reviewers
# For matches, line content do not exist.
line_content = None
message = match.message
+ time = match.time
result = Result(suspected_cl, revision_url, component_name, author, reason,
- review_url, reviewers, line_content, message)
+ review_url, reviewers, line_content, message, time)
result_list.append(result)
return result_list
@@ -561,6 +556,7 @@ def BlameListToResultList(blame_list):
reason = (
'The CL last changed line %s of file %s, which is stack frame %d.' %
(blame.line_number, blame.file, blame.stack_frame_index))
+ time = blame.time
# Blame object does not have review url and reviewers.
review_url = None
reviewers = None
@@ -568,7 +564,7 @@ def BlameListToResultList(blame_list):
message = blame.message
result = Result(suspected_cl, revision_url, component_name, author, reason,
- review_url, reviewers, line_content, message)
+ review_url, reviewers, line_content, message, time)
result_list.append(result)
return result_list
« no previous file with comments | « tools/findit/blame.py ('k') | tools/findit/findit_for_crash.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698