tools/findit/findit_for_crash.py - Issue 617073010: [Findit] Add timestamp of CL commit and fix two bugs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/findit/findit_for_crash.py

Issue 617073010: [Findit] Add timestamp of CL commit and fix two bugs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/findit/findit_for_crash.py

diff --git a/tools/findit/findit_for_crash.py b/tools/findit/findit_for_crash.py

index e0f88eacdf17e8fd7336c1c5a36f137bb81b43fe..689294987ca0b1ccb2f4efbb3889c0e5c6fc78b8 100644

--- a/tools/findit/findit_for_crash.py

+++ b/tools/findit/findit_for_crash.py

@@ -495,7 +495,7 @@ def CombineMatches(matches):

continue

# Combine the reason if the current match is already in there.

- found_match.reason += match.reason

+ found_match.reason += '\n' + match.reason

if match.min_distance < found_match.min_distance:

found_match.min_distance = match.min_distance

found_match.min_distance_info = match.min_distance_info

@@ -503,10 +503,11 @@ def CombineMatches(matches):

for stack_index, cl, match in combined_matches:

if match.min_distance_info:

file_name, min_crashed_line, min_changed_line = match.min_distance_info

- match.reason += \

- ('\nMinimum distance from crash line to modified line: %d. '

- '(file: %s, crashed on: %d, modified: %d).\n' %

- (match.min_distance, file_name, min_crashed_line, min_changed_line))

+ match.reason = match.reason.strip()

+ match.reason += (

+ '\nMinimum distance from crash line to modified line: %d. '

+ '(file: %s, crashed on: %d, modified: %d).' %

+ (match.min_distance, file_name, min_crashed_line, min_changed_line))

return combined_matches

« no previous file with comments | « tools/findit/crash_utils.py ('k') | tools/findit/git_repository_parser.py » ('j') | no next file with comments »