c/b/supervised_user: Use range-based for where appropriate.

c/b/supervised_user: Use range-based for where appropriate.

We're now allowed to use some C++11 features: http://chromium-cpp.appspot.com/ :)

This CL also includes a few cleanups (mostly includes) courtesy of "git cl lint".

BUG=

Committed: https://crrev.com/5844aca18461dfcc1db056fcc9e8ff0f7a41eebb
Cr-Commit-Position: refs/heads/master@{#297417}

[Marc Treib, 2014-09-29 13:09:55]

treib@chromium.org changed reviewers:
+ bauerb@chromium.org

[Marc Treib, 2014-09-29 13:09:55]

Woo C++11! PTAL!

(There's a few places where "auto" outside of a "for" might be useful, but I've
saved that for another CL.)

[Bernhard Bauer, 2014-09-29 16:16:52]

Woo C++11! :)

TBH, I don't think using auto here actually improves things, because a reader of
the code now needs to infer what the type of the loop variable is. Could we do
these with range-based for, but without auto types? That would already get rid
of ::iterator and the loop boilerplate.

https://codereview.chromium.org/615493005/diff/1/chrome/browser/supervised_us...
File chrome/browser/supervised_user/supervised_user_service.cc (right):

https://codereview.chromium.org/615493005/diff/1/chrome/browser/supervised_us...
chrome/browser/supervised_user/supervised_user_service.cc:494: const
extensions::ExtensionSet& extensions = *extension_service->extensions();
What do we need this for?

[Marc Treib, 2014-09-30 09:28:05]

Agreed - I originally read the style guide as "use auto unless you want copies",
but turns out it doesn't actually say that. I've removed most uses of auto,
except for a few cases of iterating over callbacks, where the auto just hides a
not-super-useful typedef anyway (but is much shorter).

Now we actually see the type of the loop variable, not just the type of some
iterator :) (e.g. there's one case where the iterator's value_type is a
scoped_refptr.. ugh).

https://codereview.chromium.org/615493005/diff/1/chrome/browser/supervised_us...
File chrome/browser/supervised_user/supervised_user_service.cc (right):

https://codereview.chromium.org/615493005/diff/1/chrome/browser/supervised_us...
chrome/browser/supervised_user/supervised_user_service.cc:494: const
extensions::ExtensionSet& extensions = *extension_service->extensions();
On 2014/09/29 16:16:52, Bernhard Bauer wrote:
> What do we need this for?

We don't - leftover from the old version. Inlined below.

[Bernhard Bauer, 2014-09-30 10:02:08]

Very nice! LGTM

https://codereview.chromium.org/615493005/diff/60001/chrome/browser/supervise...
File chrome/browser/supervised_user/supervised_user_service.cc (right):

https://codereview.chromium.org/615493005/diff/60001/chrome/browser/supervise...
chrome/browser/supervised_user/supervised_user_service.cc:103: /// TODO(bauerb):
This is kinda ugly.
While you're here, could you remove the extra slash here?

https://codereview.chromium.org/615493005/diff/60001/chrome/browser/supervise...
chrome/browser/supervised_user/supervised_user_service.cc:494: for (const
scoped_refptr<const extensions::Extension>& extension :
Hm... I guess unwrapping the scoped_refptr here wouldn't work, right?

[Marc Treib, 2014-09-30 10:21:49]

https://codereview.chromium.org/615493005/diff/60001/chrome/browser/supervise...
File chrome/browser/supervised_user/supervised_user_service.cc (right):

https://codereview.chromium.org/615493005/diff/60001/chrome/browser/supervise...
chrome/browser/supervised_user/supervised_user_service.cc:103: /// TODO(bauerb):
This is kinda ugly.
On 2014/09/30 10:02:07, Bernhard Bauer wrote:
> While you're here, could you remove the extra slash here?

Done.

https://codereview.chromium.org/615493005/diff/60001/chrome/browser/supervise...
chrome/browser/supervised_user/supervised_user_service.cc:494: for (const
scoped_refptr<const extensions::Extension>& extension :
On 2014/09/30 10:02:08, Bernhard Bauer wrote:
> Hm... I guess unwrapping the scoped_refptr here wouldn't work, right?

I don't think that's possible (is it?)
As it is, this is quite ugly, but at least now the type is visible, so I think
it's a huge improvement over the old version.

[Marc Treib, 2014-09-30 10:34:10]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2014-09-30 10:34:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/615493005/60001

[Marc Treib, 2014-09-30 12:13:30]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2014-09-30 12:14:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/615493005/80001

[commit-bot: I haz the power, 2014-09-30 12:58:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-30 12:58:52]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Marc Treib, 2014-09-30 13:30:04]

The CQ bit was checked by treib@chromium.org

[commit-bot: I haz the power, 2014-09-30 13:31:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/615493005/100001

[commit-bot: I haz the power, 2014-09-30 14:08:45]

Committed patchset #6 (id:100001) as 58bf95c7042b2b7775378530e6b3f0df98c73cb9

[commit-bot: I haz the power, 2014-09-30 14:09:31]

Patchset 6 (id:??) landed as
https://crrev.com/5844aca18461dfcc1db056fcc9e8ff0f7a41eebb
Cr-Commit-Position: refs/heads/master@{#297417}