chrome/browser/supervised_user/supervised_user_pref_store.cc - Issue 615493005: c/b/supervised_user: Use range-based for where appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_pref_store.cc

Issue 615493005: c/b/supervised_user: Use range-based for where appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix CrOS Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_pref_store.h ('k') | chrome/browser/supervised_user/supervised_user_registration_utility_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_pref_store.cc

diff --git a/chrome/browser/supervised_user/supervised_user_pref_store.cc b/chrome/browser/supervised_user/supervised_user_pref_store.cc

index 5d0dab4fab865be001d04e005ee4303afa394757..71eacd3ff03088c9774a0a54b9e8502d1658e083 100644

--- a/chrome/browser/supervised_user/supervised_user_pref_store.cc

+++ b/chrome/browser/supervised_user/supervised_user_pref_store.cc

@@ -4,6 +4,8 @@

#include "chrome/browser/supervised_user/supervised_user_pref_store.h"

+#include <vector>

#include "base/bind.h"

#include "base/prefs/pref_value_map.h"

#include "base/values.h"

@@ -119,9 +121,7 @@ void SupervisedUserPrefStore::OnNewSettingsAvailable(

prefs_->GetDifferingKeys(old_prefs.get(), &changed_prefs);

// Send out change notifications.

- for (std::vector<std::string>::const_iterator pref(changed_prefs.begin());

- pref != changed_prefs.end();

- ++pref) {

- FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(*pref));

+ for (const std::string& pref : changed_prefs) {

+ FOR_EACH_OBSERVER(Observer, observers_, OnPrefValueChanged(pref));

}