chrome/browser/supervised_user/supervised_user_sync_service_unittest.cc - Issue 615493005: c/b/supervised_user: Use range-based for where appropriate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/supervised_user/supervised_user_sync_service_unittest.cc

Issue 615493005: c/b/supervised_user: Use range-based for where appropriate. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix CrOS Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/supervised_user/supervised_user_sync_service.cc ('k') | chrome/browser/supervised_user/supervised_user_url_filter.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/supervised_user/supervised_user_sync_service_unittest.cc

diff --git a/chrome/browser/supervised_user/supervised_user_sync_service_unittest.cc b/chrome/browser/supervised_user/supervised_user_sync_service_unittest.cc

index 748976a111547b247683e92ca6eaf69cf07b1b84..525526893ee30fa3024ee0deca8957c0d0c25654 100644

--- a/chrome/browser/supervised_user/supervised_user_sync_service_unittest.cc

+++ b/chrome/browser/supervised_user/supervised_user_sync_service_unittest.cc

@@ -68,10 +68,9 @@ SyncError MockChangeProcessor::ProcessSyncChanges(

}

SyncChange MockChangeProcessor::GetChange(const std::string& id) const {

- for (SyncChangeList::const_iterator it = change_list_.begin();

- it != change_list_.end(); ++it) {

- if (it->sync_data().GetSpecifics().managed_user().id() == id)

- return *it;

+ for (const SyncChange& sync_change : change_list_) {

+ if (sync_change.sync_data().GetSpecifics().managed_user().id() == id)

+ return sync_change;

}

return SyncChange();

}